-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lambda): add tracingMode
property to a Function
#32320
Conversation
tracingConfig
property to a Function
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32320 +/- ##
=======================================
Coverage 78.86% 78.86%
=======================================
Files 108 108
Lines 7165 7165
Branches 1319 1319
=======================================
Hits 5651 5651
Misses 1330 1330
Partials 184 184
Flags with carried forward coverage won't be shown. Click here to find out more.
|
* | ||
* To sample and record incoming requests, set tracingMode to Active | ||
* | ||
* @default TracingMode.PASS_THROUGH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When deployed with tracingMode set to undefined
, PassThrough
was set, so I assume PassThrough
is the default value.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
tracingConfig
property to a FunctiontracingMode
property to a Function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution.
Just one question.
It seems that tracing config has already been implemented. Am I correct?
resource.tracingConfig = this.buildTracingConfig(props.tracing ?? Tracing.ACTIVE); |
Please let me know if I'm mistaken.
I apologize, I overlooked that implementation... Should I remove |
@ren-yamanashi |
Comments on closed issues and PRs are hard for our team to see. |
Reason for this change
We can set a
tracingMode
for an Function(Lambda) from cloudformation, but this was not supported in the AWS CDK L2 construct.Description of changes
Add
tracingMode
property to FunctionProps and set it in the CfnFunction.Description of how you validated changes
Added both unit and integration tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license