Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix build errors in fsharp init-template #3229

Merged
merged 1 commit into from
Jul 7, 2019

Conversation

mikhailshilkov
Copy link
Contributor

Fixes #3228.

Improved the F# template to match the C# one:

  • Add a reference to Amazon.CDK.AWS.SNS.Subscriptions
  • Use topic.AddSubscription instead of SubscribeQueue
  • Use float instead of int for Duration constructor
  • Make the code look a bit more like idiomatic F#, e.g. get rid of unneeded mutable

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mikhailshilkov mikhailshilkov requested a review from a team as a code owner July 7, 2019 11:03
@ghost ghost requested a review from rix0rrr July 7, 2019 11:03
@eladb eladb merged commit 7d020f1 into aws:master Jul 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fsharp init template doesn't compile
2 participants