-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cdk): changed retry mechanism for hotswapping AppSync.function #32179
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
The code change is correct, but we need at least some unit tests for it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32179 +/- ##
==========================================
+ Coverage 78.60% 78.66% +0.05%
==========================================
Files 107 107
Lines 7161 7161
Branches 1320 1320
==========================================
+ Hits 5629 5633 +4
+ Misses 1347 1343 -4
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Hi @otaviomacedo, unit tests have been added that should cover the new change. When you have time would you be able to take a look at the updates? |
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
Could this PR receive an Exemption Request? It does not make sense for this code change to include an Integration test change. |
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Reason for this change
Fixing bug in hotswap for
AppSync.function
whereConcurrentModificationException
error continues to appear when attempting hotswap on a large collection of resources.Description of changes
Switches the retry mechanism for hotswapping AppSync.function from a simple retry where hotswap of AppSync.function is retried 5 times at 1 second intervals if a Concurrent Modification Exception occurs to an exponential back off retry, where the retry interval doubles with each failure.
Exponential backoff will try 6 times (which through my testing should cover all reasonable cases) to resolve AppSync.function hotswap.
Description of how you validated changes
No integration or unit tests added. Passes all current unit tests.
Tested locally on an Amplify project to ensure that cases that previously experienced
ConcurrentModificationException
errors no longer experienced them.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license