-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ec2): expose EntryProperty #32060
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Note: I have opted to rerun the existing tests rather than add explicit integration tests, as I believe they are not necessary in this case. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32060 +/- ##
=======================================
Coverage ? 77.17%
=======================================
Files ? 105
Lines ? 7169
Branches ? 1315
=======================================
Hits ? 5533
Misses ? 1455
Partials ? 181
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
Comments on closed issues and PRs are hard for our team to see. |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
Issue # (if applicable)
No.
Reason for this change
The current implementation does not expose
EntryProperty
, making it cumbersome for users to directly specify entries forPrefixList
. To improve accessibility and flexibility, this change introduces an accessible interface for defining prefix list entries, allowing users to interact withentries
more intuitively.Description of changes
PrefixListEntry
interface that mirrors the properties ofCfnPrefixList.EntryProperty
while simplifying access.Description of how you validated changes
PrefixList
instances can now acceptPrefixListEntry
arrays, and they are converted correctly intoCfnPrefixList.EntryProperty
.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license