Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ecs): grant drain-hook policy container-instance permissions #3199

Merged
merged 4 commits into from
Jul 4, 2019
Merged

fix(ecs): grant drain-hook policy container-instance permissions #3199

merged 4 commits into from
Jul 4, 2019

Commits on Jul 4, 2019

  1. fix(ecs): grant drain-hook policy container-instance permissions 

    UpdateContainerInstanceState and ListTask APIs require permissions on
a container-instance resource, rather than a cluster resource. This
change updates the policy to:

1. remove the cluster as the resource restriction
2. add the cluster as a resource condition

More info on ECS Resource-Level permissions can be found here:
https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ecs-supported-iam-actions-resources.html

Fixes aws#3190
    @kohidave @piradeepk
    kohidave authored and piradeepk committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    8c6c9ca View commit details
    Browse the repository at this point in the history

  2. fix failing test

    @piradeepk
    piradeepk committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    f0c1ca6 View commit details
    Browse the repository at this point in the history

  3. Address feedback

    @piradeepk
    piradeepk committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    7c4fb25 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into fix-drainhook

    Elad Ben-Israel committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    fcb1b87 View commit details
    Browse the repository at this point in the history