Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ecs): ECS drain hook can't change instance state to draining #3198

Closed
wants to merge 2 commits into from
Closed

fix(ecs): ECS drain hook can't change instance state to draining #3198

wants to merge 2 commits into from

Conversation

ScOut3R
Copy link
Contributor

@ScOut3R ScOut3R commented Jul 4, 2019

The UpdateContainerInstancesState permission was scoped to the ECS cluster while it should be scoped to the container instance.

The documentation referenced in #3190 puts the cluster name in the container instance ARN but that's not the case in my experience with legacy and long ARNs.

@ScOut3R
fix(ecs): ECS drain hook can't change instance state to draining (aws…
caaee9e 
…#3190)

The UpdateContainerInstancesState permission was scoped to the ECS cluster
while it should be scoped to the container instance.

fixes aws#3190
@ScOut3R
fix(ecs): ECS drain hook can't change instance state to draining (aws…
150e3a8 
…#3190)

update integration test data

fixes aws#3190
@ScOut3R ScOut3R requested review from SoManyHs and a team as code owners July 4, 2019 02:44
@eladb
Copy link
Contributor

eladb commented Jul 4, 2019

Seems like a duplicate of #3198, correct? @pkandasamy91 can you confirm?

@rix0rrr
Copy link
Contributor

rix0rrr commented Jul 4, 2019

Already merged the other one, sorry.

@rix0rrr rix0rrr closed this Jul 4, 2019
@piradeepk
Copy link
Contributor

@eladb @rix0rrr it's attempting to resolve the same issue, but the implementation is different. We decided to use conditions instead as container instance arns would vary based on if a customer has opted into using long arns or if the customer used the older arn format.

@ScOut3R ScOut3R deleted the fix/ecs-drain-hook-cant-change-instance-state branch September 9, 2019 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoManyHs SoManyHs Awaiting requested review from SoManyHs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ScOut3R @eladb @rix0rrr @piradeepk