Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(release): 2.162.1 #31732

Merged
merged 4 commits into from
Oct 11, 2024
Merged

chore(release): 2.162.1 #31732

merged 4 commits into from
Oct 11, 2024

Commits on Oct 11, 2024

  1. fix(cli): cdk import errors with 'S3 error: Access Denied' (#31727) 

    In #31597 we changed `cdk diff` to always use the file asset publishing role, instead of direct CLI credentials. This included a refactor that impacted `cdk import`, which was now not uploading the stack template at all anymore. The operation that is now broken only happens in a case with interactive input, which is why this wasn't caught by integ tests.

In this change, put the requisite asset-handling code around `makeBodyParameter` to make the asset uploading happen properly.

In future PRs:

- Add an integration test for `cdk import` which would have exposed the same error.
- Refactor the contract of `makeBodyParameter`, and perhaps more around asset uploading, to make the expectations and promises of that function more clear; right now it was not obvious what the function would and wouldn't do for you, which led to this error.

I did some refactorings in this PR already (renames, removing an unused argument). I saw an opportunity for more but didn't want to add risk and delay to this patch. Hence, forthcoming 😄 .

Closes #31716.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    @rix0rrr @kaizencc
    rix0rrr authored and kaizencc committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    5c2787a View commit details
    Browse the repository at this point in the history

  2. chore(release): 2.162.1

    @kaizencc
    kaizencc committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    9615eb8 View commit details
    Browse the repository at this point in the history

  3. chore: update CHANGELOG.v2.md

    @kaizencc
    kaizencc committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    c8f68a2 View commit details
    Browse the repository at this point in the history

  4. chore: update CHANGELOG.v2.alpha.md

    @kaizencc
    kaizencc committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    142392e View commit details
    Browse the repository at this point in the history