Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(codebuild): updated Linux build image return type in doc #31718

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

khushail
Copy link
Contributor

@khushail khushail commented Oct 10, 2024

Issue # (if applicable)

Closes #31717

Reason for this change

It should be in sync with the description as mentioned in here https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_codebuild.LinuxArmBuildImage.html

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added effort/small Small work item – less than a day of effort p2 labels Oct 10, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team October 10, 2024 19:19
@khushail khushail changed the title Updated Linux build image type in doc docs(aws-codebuild): Updated Linux build image return type in doc Oct 10, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@khushail khushail marked this pull request as ready for review October 10, 2024 19:22
@khushail
Copy link
Contributor Author

Exemption Request

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Oct 10, 2024
@khushail khushail changed the title docs(aws-codebuild): Updated Linux build image return type in doc docs(aws-codebuild): updated Linux build image return type in doc Oct 10, 2024
@khushail khushail changed the title docs(aws-codebuild): updated Linux build image return type in doc docs(codebuild): updated Linux build image return type in doc Oct 10, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 10, 2024 19:27

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: bf962fb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 10, 2024
Copy link
Contributor

mergify bot commented Oct 10, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 048975e into main Oct 10, 2024
27 of 29 checks passed
@mergify mergify bot deleted the khushail/aws-codebuild branch October 10, 2024 20:29
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
effort/small Small work item – less than a day of effort p2 pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-cdk-lib/aws-codebuild: Incorrect documentation on LinuxArmBuildImage
3 participants