-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): garbage collect s3 assets (under --unstable
flag)
#31611
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
New protocol for `--unstable` is documented here and being used in #31611 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Co-authored-by: Rico Hermans <rix0rrr@gmail.com>
Co-authored-by: Rico Hermans <rix0rrr@gmail.com>
packages/aws-cdk/lib/api/garbage-collection/garbage-collector.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk/lib/api/garbage-collection/garbage-collector.ts
Outdated
Show resolved
Hide resolved
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
S3 Asset Garbage Collection
This PR introduces a new CLI command under the new
--unstable
flag. This flag ensures that users understand and opt-in to experimental or incomplete CLI features.cdk gc
will garbage collect unused assets in your bootstrapped S3 bucket. It goes through each object in the bucket, checks to see if the asset hash shows up in a cloudformation stack, and if not, tags the object as unused and/or deletes the object (depending on your configuration).THIS COMMAND WILL DELETE OBJECTS IN YOUR BOOTSTRAPPED S3 BUCKET
basic garbage collection (immediately deletes objects that are unused):
garbage collection with a buffer (deletes unused objects > # of days specified):
garbage collection with a created at buffer (deletes unused objects only if they have lived longer than this many days):
garbage collect a specific bootstrap stack:
before actually deleting your assets, you will be prompted one last time:
To disable this, specify the
--skip-delete-prompt
option.Todo in another PR
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license