feat(s3-deployment): added property outputObjectKeys for BucketDeployment

[moelasmar]

Issue # (if applicable)

Closes #28579

Reason for this change

The CR lambda is essentially sending back the same data in the response which is hitting the limit for close to 50 object uploads.

Particularly this is being a limitation when using servicecatalog.ProductStack, if there are local assets beyond a particular number, the Custom::CDKBucketDeployment would fail with the error Response object is too long which is a hard limit of 4096 bytes.

Description of changes

1. Added a new property to control the custom resource sending large data and hitting the 4096 bytes limit even though the deployment operation is successful.
2. The property outputObjectKeys has been set to false by default for the service catalog product so that the error does not occur.

Description of how you validated changes

Validated using a sample stack with the property set and confirmed the behavior. Also, the existing deployments would be unaffected.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[Leo10Gama]

LGTM aside from a few minor comments. Just want to verify the default behaviour and whether or not we should test when objectOutputKeys: true is set as well.

[Leo10Gama]

Should we also verify that the previous behaviour still exists as well? That is, have a unit test to check that when OutputObjectKeys is true, the object keys are in the output?

[Leo10Gama]

May also be worth having a test to verify the default value of the attribute

[moelasmar]

added, check integration test cases: packages/@aws-cdk-testing/framework-integ/test/aws-s3-deployment/test/integ.bucket-deployment-big-response.ts && packages/@aws-cdk-testing/framework-integ/test/aws-s3-deployment/test/integ.bucket-deployment.ts

[Leo10Gama]

Changes look good! Just one check regarding one of the integ tests.

[Leo10Gama]

LGTM. Awesome work, thanks!!

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 1de12fc
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.