fix(lambda): configuring log retention fails on 70+ Lambdas #31340
Conversation
When the Log Retention Lambda runs massively parallel (on 70+ Lambdas at the same time), it can run into throttling problems and fail. Raise the retry count and delays: - Raise the default amount of retries from 5 -> 10 - Raise the sleep base from 100ms to 1s. - Change the sleep calculation to apply the 10s limit *after* jitter instead of before (previously, we would take a fraction of 10s; now we're taking a fraction of the accumulated wait time, and after calculating that limit it to 10s). Fixes #31338.
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
rix0rrr
added
the
pr-linter/exempt-integ-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
| delayBase: number = 100, | ||
| delayCap = 10 * 1000, // 10s | ||
| delayBase: number = 1_000, | ||
| delayCap = 60_000, // 60s |
There was a problem hiding this comment.
Nit: PR description says you cap at 10s, but this says 60s.
github-actions
bot
added
the
effort/medium
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
When the Log Retention Lambda runs massively parallel (on 70+ Lambdas at the same time), it can run into throttling problems and fail.
Raise the retry count and delays:
Fixes #31338.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license