Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(code): make CfnResource#_toCloudFormation null-safe #3121

Merged
merged 7 commits into from
Jul 1, 2019
Merged

fix(code): make CfnResource#_toCloudFormation null-safe #3121

merged 7 commits into from
Jul 1, 2019

Commits on Jun 28, 2019

  1. fix(code): make CfnResource#_toCloudFormation null-safe 

    The `CfnResource#_toCloudFormation` method creates a `PostResolveToken`
with a post-processor that was not ready to handle the absence of
`Properties` on the resolved value. It is however possible that
`Properties` are missing when an object is created with the default
configuration (e.g: by `new sqs.CfnQueue(this, 'Queue');`).

This change makes the post-processor function correctly handle
`undefined` in this case.

Related #3093
    @RomainMuller
    RomainMuller committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    6a5266f View commit details
    Browse the repository at this point in the history

  2. test: what happens

    @RomainMuller
    RomainMuller committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    ae331d9 View commit details
    Browse the repository at this point in the history

  3. Fix problem

    @RomainMuller
    RomainMuller committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    06e68a9 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2019

  1. Merge branch 'master' into rmuller/fix-cfnresource-tocloudformation

    @RomainMuller
    RomainMuller authored Jul 1, 2019
    Configuration menu
    Copy the full SHA
    cd68cd0 View commit details
    Browse the repository at this point in the history

  2. fix: undefined-erasing bug

    @RomainMuller
    RomainMuller committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    47fd637 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into rmuller/fix-cfnresource-tocloudformation

    @RomainMuller
    RomainMuller authored Jul 1, 2019
    Configuration menu
    Copy the full SHA
    3423e7c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into rmuller/fix-cfnresource-tocloudformation

    Elad Ben-Israel authored Jul 1, 2019
    Configuration menu
    Copy the full SHA
    3382a11 View commit details
    Browse the repository at this point in the history