Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kinesisfirehose-alpha): add ca-west-1 Firehose CIDR block #31206

Merged
merged 12 commits into from
Sep 4, 2024
Merged

chore(kinesisfirehose-alpha): add ca-west-1 Firehose CIDR block #31206

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a230b66
fix(kinesisfirehose-alpha): add ca-west-1 Firehose CIDR block
paulhcsun Aug 23, 2024
49ef911
Merge branch 'main' into kinesis-firehouse-ca-west-1
paulhcsun Aug 23, 2024
0608a22
fix CIDR block
paulhcsun Aug 27, 2024
5c4e7bf
update snapshots
paulhcsun Aug 27, 2024
e3a1add
Merge branch 'main' into kinesis-firehouse-ca-west-1
paulhcsun Aug 27, 2024
88cf49b
manually update cidr block value
paulhcsun Aug 27, 2024
b2978d6
update CIDR in fact table
paulhcsun Aug 28, 2024
0b11643
Merge branch 'main' into kinesis-firehouse-ca-west-1
paulhcsun Aug 29, 2024
9701fdb
update snapshots
paulhcsun Aug 29, 2024
bcbb7f8
snapshots
paulhcsun Aug 29, 2024
957bf52
Merge branch 'main' into kinesis-firehouse-ca-west-1
paulhcsun Sep 4, 2024
399c3d0
Merge branch 'main' into kinesis-firehouse-ca-west-1
mergify[bot] Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...alpha/test/integ.delivery-stream.js.snapshot/aws-cdk-firehose-delivery-stream.assets.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions ...pha/test/integ.delivery-stream.js.snapshot/aws-cdk-firehose-delivery-stream.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,9 @@
"ca-central-1": {
"FirehoseCidrBlock": "35.183.92.128/27"
},
"ca-west-1": {
"FirehoseCidrBlock": "40.176.98.192/27/27"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 40.176.98.192/27. There is an extra /27 at the end.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why but this keeps getting automatically updated with the extra /27 and overriding my changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realized I was not updating the value in the correct place. It should be fixed now.

},
"cn-north-1": {
"FirehoseCidrBlock": "52.81.151.32/27"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-kinesisfirehose-alpha/test/integ.delivery-stream.js.snapshot/cdk.out
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...ages/@aws-cdk/aws-kinesisfirehose-alpha/test/integ.delivery-stream.js.snapshot/integ.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ...s/@aws-cdk/aws-kinesisfirehose-alpha/test/integ.delivery-stream.js.snapshot/manifest.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-kinesisfirehose-alpha/test/integ.delivery-stream.js.snapshot/tree.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions ...ream.source-stream.js.snapshot/aws-cdk-firehose-delivery-stream-source-stream.assets.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions ...am.source-stream.js.snapshot/aws-cdk-firehose-delivery-stream-source-stream.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,9 @@
"ca-central-1": {
"FirehoseCidrBlock": "35.183.92.128/27"
},
"ca-west-1": {
"FirehoseCidrBlock": "40.176.98.192/27/27"
},
"cn-north-1": {
"FirehoseCidrBlock": "52.81.151.32/27"
},
Expand Down
2 changes: 1 addition & 1 deletion ...dk/aws-kinesisfirehose-alpha/test/integ.delivery-stream.source-stream.js.snapshot/cdk.out
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...aws-kinesisfirehose-alpha/test/integ.delivery-stream.source-stream.js.snapshot/integ.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ...-kinesisfirehose-alpha/test/integ.delivery-stream.source-stream.js.snapshot/manifest.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions ...teg.kinesis-stream-events-target.js.snapshot/aws-cdk-firehose-delivery-stream.assets.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions ...g.kinesis-stream-events-target.js.snapshot/aws-cdk-firehose-delivery-stream.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,9 @@
"ca-central-1": {
"FirehoseCidrBlock": "35.183.92.128/27"
},
"ca-west-1": {
"FirehoseCidrBlock": "40.176.98.192/27/27"
},
"cn-north-1": {
"FirehoseCidrBlock": "52.81.151.32/27"
},
Expand Down
2 changes: 1 addition & 1 deletion ...cdk/aws-kinesisfirehose-alpha/test/integ.kinesis-stream-events-target.js.snapshot/cdk.out
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .../aws-kinesisfirehose-alpha/test/integ.kinesis-stream-events-target.js.snapshot/integ.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...is-stream-events-target.js.snapshot/integtestsDefaultTestDeployAssert44C8D370.assets.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ...s-kinesisfirehose-alpha/test/integ.kinesis-stream-events-target.js.snapshot/manifest.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading