Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): configure Stack SNS notification ARNs on the Stack construct #31107

Merged
merged 69 commits into from
Sep 23, 2024
Merged

feat(core): configure Stack SNS notification ARNs on the Stack construct #31107

merged 69 commits into from
Sep 23, 2024

Commits on Jun 11, 2024

  1. working basic implementation

    @comcalvi
    comcalvi committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    48f5b63 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Merge branch 'main' of github.com:aws/aws-cdk into comcalvi/notificat… 

    …ion-arns
    @comcalvi
    comcalvi committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    f05b908 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:aws/aws-cdk into comcalvi/notificat… 

    …ion-arns
    @comcalvi
    comcalvi committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    868cb1f View commit details
    Browse the repository at this point in the history

  3. fix

    @comcalvi
    comcalvi committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    f5c930b View commit details
    Browse the repository at this point in the history

  4. don't skip deploy if stack notifications arnrns have changed

    @comcalvi
    comcalvi committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    662697d View commit details
    Browse the repository at this point in the history

  5. more changes

    @comcalvi
    comcalvi committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    bc0afea View commit details
    Browse the repository at this point in the history

  6. cleanup

    @comcalvi
    comcalvi committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    b3a5716 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. most tests working

    @comcalvi
    comcalvi committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    4b88b03 View commit details
    Browse the repository at this point in the history

  2. toolkit tests

    @comcalvi
    comcalvi committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    af40c5e View commit details
    Browse the repository at this point in the history

  3. docs

    @comcalvi
    comcalvi committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    ffaf14e View commit details
    Browse the repository at this point in the history

  4. remove the bad cast, it is evil

    @comcalvi
    comcalvi committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    055d496 View commit details
    Browse the repository at this point in the history

  5. cleanup

    @comcalvi
    comcalvi committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    fc184cc View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' of github.com:aws/aws-cdk into comcalvi/notificat… 

    …ion-arns
    @comcalvi
    comcalvi committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    fac1245 View commit details
    Browse the repository at this point in the history

  7. silly licenses

    @comcalvi
    comcalvi committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    5e606af View commit details
    Browse the repository at this point in the history

  8. newline\n...

    @comcalvi
    comcalvi committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    180066b View commit details
    Browse the repository at this point in the history

  9. foo

    @comcalvi
    comcalvi committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    2bc9320 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. small change to trigger test pipeline

    @comcalvi
    comcalvi committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    e9f9fa4 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. destroy fix hopefully

    @comcalvi
    comcalvi committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    48b8e49 View commit details
    Browse the repository at this point in the history

  2. jest......

    @comcalvi
    comcalvi committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    effc510 View commit details
    Browse the repository at this point in the history

  3. tests...jest....

    @comcalvi
    comcalvi committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    8e7fc27 View commit details
    Browse the repository at this point in the history

  4. ok, fine then...

    @comcalvi
    comcalvi committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    e3f2a5c View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. logging for this at this point

    @comcalvi
    comcalvi committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    8cd8f6e View commit details
    Browse the repository at this point in the history

  2. throw the error then

    @comcalvi
    comcalvi committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    f605e1d View commit details
    Browse the repository at this point in the history

  3. type error

    @comcalvi
    comcalvi committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    8848d0a View commit details
    Browse the repository at this point in the history

  4. man this is painful

    @comcalvi
    comcalvi committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    c5201ed View commit details
    Browse the repository at this point in the history

  5. woowoowoowoo

    @comcalvi
    comcalvi committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    6c6616e View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. selector

    @comcalvi
    comcalvi committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    d5b9a80 View commit details
    Browse the repository at this point in the history

  2. jest

    @comcalvi
    comcalvi committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    c718b20 View commit details
    Browse the repository at this point in the history

  3. jest

    @comcalvi
    comcalvi committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    335d6dd View commit details
    Browse the repository at this point in the history

  4. jest

    @comcalvi
    comcalvi committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    cbde013 View commit details
    Browse the repository at this point in the history

  5. jest

    @comcalvi
    comcalvi committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    e9b0ddf View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. cloud assem

    @comcalvi
    comcalvi committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    8bd64ea View commit details
    Browse the repository at this point in the history

  2. wowzers

    @comcalvi
    comcalvi committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    83cc722 View commit details
    Browse the repository at this point in the history

  3. asm

    @comcalvi
    comcalvi committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    2c9884f View commit details
    Browse the repository at this point in the history

  4. asm

    @comcalvi
    comcalvi committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    2539c9c View commit details
    Browse the repository at this point in the history

  5. asm

    @comcalvi
    comcalvi committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    ad71122 View commit details
    Browse the repository at this point in the history

  6. asm

    @comcalvi
    comcalvi committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    45357e1 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. finally fixed it......

    @comcalvi
    comcalvi committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    abd6dc4 View commit details
    Browse the repository at this point in the history

  2. fixed

    @comcalvi
    comcalvi committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    178e712 View commit details
    Browse the repository at this point in the history

  3. done

    @comcalvi
    comcalvi committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    4fbdaa4 View commit details
    Browse the repository at this point in the history

  4. code teleports to a different line in the file

    @comcalvi
    comcalvi committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    d1bf1a0 View commit details
    Browse the repository at this point in the history

  5. toolkit test

    @comcalvi
    comcalvi committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    67188db View commit details
    Browse the repository at this point in the history

  6. toolkit

    @comcalvi
    comcalvi committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    f00ed25 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Merge branch 'main' of github.com:aws/aws-cdk into comcalvi/notificat… 

    …ion-arns
    @comcalvi
    comcalvi committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    a20f0e7 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Merge branch 'main' of github.com:aws/aws-cdk into comcalvi/notificat… 

    …ion-arns
    @comcalvi
    comcalvi committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    c885502 View commit details
    Browse the repository at this point in the history

  2. wowowo cli integ test

    @comcalvi
    comcalvi committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    c38e7a4 View commit details
    Browse the repository at this point in the history

  3. integ-fix

    @comcalvi
    comcalvi committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    f79368f View commit details
    Browse the repository at this point in the history

  4. fix deploy all test

    @comcalvi
    comcalvi committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    b03209d View commit details
    Browse the repository at this point in the history

  5. wowowo

    @comcalvi
    comcalvi committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    22bb7e8 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. fixing the cli test framework

    @comcalvi
    comcalvi committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    bf5deb9 View commit details
    Browse the repository at this point in the history

  2. fix

    @comcalvi
    comcalvi committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    95e8dac View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. fix the busted test

    @comcalvi
    comcalvi committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    4331c91 View commit details
    Browse the repository at this point in the history

  2. fix

    @comcalvi
    comcalvi committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    f4c65a2 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Merge branch 'main' of github.com:aws/aws-cdk into comcalvi/notificat… 

    …ion-arns
    @comcalvi
    comcalvi committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    f704997 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. typo 

    Co-authored-by: Parker Scanlon <69879391+scanlonp@users.noreply.github.com>
    @comcalvi @scanlonp
    comcalvi and scanlonp committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    b1c116e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:aws/aws-cdk into comcalvi/notificat… 

    …ion-arns
    @comcalvi
    comcalvi committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    0bc224f View commit details
    Browse the repository at this point in the history

  3. changes: 

    '
    @comcalvi
    comcalvi committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    79b2e7d View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. fix

    @comcalvi
    comcalvi committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    e933382 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. schema

    @comcalvi
    comcalvi committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    6b447a1 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. cli integ test conflicts

    @comcalvi
    comcalvi committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    a428809 View commit details
    Browse the repository at this point in the history

  2. build

    @comcalvi
    comcalvi committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    817c959 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. conflicts

    @comcalvi
    comcalvi committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    a40985c View commit details
    Browse the repository at this point in the history

  2. deps + test

    @comcalvi
    comcalvi committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    f5aafad View commit details
    Browse the repository at this point in the history

  3. bump cdk-assets

    @comcalvi
    comcalvi committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    8dd5ce9 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into comcalvi/notification-arns

    @comcalvi
    comcalvi committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    b376437 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Merge branch 'main' of github.com:aws/aws-cdk into comcalvi/notificat… 

    …ion-arns
    @comcalvi
    comcalvi committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    f45f4f6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:aws/aws-cdk into comcalvi/notificat… 

    …ion-arns
    @comcalvi
    comcalvi committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    8323e18 View commit details
    Browse the repository at this point in the history

  3. more version fun

    @comcalvi
    comcalvi committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    b8ad5f3 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Merge branch 'main' into comcalvi/notification-arns

    @mergify
    mergify[bot] committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    4977203 View commit details
    Browse the repository at this point in the history