-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ec2): add enableAcceptanceRequired
function for VpcEndpointService
#30923
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
acceptanceRequired
for VpcEndpointService
enableAcceptanceRequired
function for VpcEndpointService
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍 Left a couple of suggestions on the documentation
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
@lpizzinidev Thank you for your review! |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Closing this PR as, unfortunately, we cannot accept changes like this. By allowing this value to be altered later in execution, it becomes unclear what the source of truth is for this property. There isn't a good enough reason to change the value outside of the constructor, and while adding in this functionality would cover a few specific use cases of toggling it off and on to add connections, it would ultimately degrade the user experience overall. |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #30192.
Reason for this change
Adding this feature in aws_ec2.VpcEndpointService will bring it to the level of console and lower level construct. With this feature, I can disable it in CDK for a short time to add intended connections and enable it again for security. Currently, someone with admin privileges need to monitor the console for requests, accept it manually and then ket the deployment continue which adds unnecessary overhead to automating the process.
Description of changes
Add
enableAcceptanceRequired
method to theec2.VpcEndpointService
class.Description of how you validated changes
Add both unit and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license