-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pipelines): add feature to display all changesets for stage before manual approval step + added postPrepare Step #30855
Conversation
…ve level. Further added the possibility to set all prepare nodes at first in a stage
Rebase with master
...k-testing/framework-integ/test/pipelines/test/integ.newpipeline-with-allPrepareNodesFirst.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk-testing/framework-integ/test/pipelines/test/integ.newpipeline-with-vpc.ts
Outdated
Show resolved
Hide resolved
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Hey @Nico-DB, it looks like the build is failing with some more serious errors. It appears that some tests are failing with destructive changes. We generally cannot give a review until the build is passing. Also if these destructive changes are necessary or intended, we will need a strong justification. |
Hey @scanlonp, |
This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
Comments on closed issues and PRs are hard for our team to see. |
Describe the feature
I would like to "run" all changesets of a stage at first, then have a manual approval step and then perform the execute change set in the original run-order.
Use Case
The use case is, that we would like to check the changesets for all stacks of an environment, to be able to perform a qualified manual approval.
Closes #24072.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license