Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pipelines): add feature to display all changesets for stage before manual approval step + added postPrepare Step #30855

Closed
wants to merge 30 commits into from

Conversation

Nico-DB
Copy link

@Nico-DB Nico-DB commented Jul 15, 2024

Describe the feature

I would like to "run" all changesets of a stage at first, then have a manual approval step and then perform the execute change set in the original run-order.

Use Case

The use case is, that we would like to check the changesets for all stacks of an environment, to be able to perform a qualified manual approval.

Closes #24072.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team July 15, 2024 08:25
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/medium Medium work item – several days of effort labels Jul 15, 2024
@github-actions github-actions bot added feature-request A feature should be added or improved. p2 labels Jul 15, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 00f9849
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@scanlonp
Copy link
Contributor

Hey @Nico-DB, it looks like the build is failing with some more serious errors. It appears that some tests are failing with destructive changes. We generally cannot give a review until the build is passing. Also if these destructive changes are necessary or intended, we will need a strong justification.

@Nico-DB
Copy link
Author

Nico-DB commented Jul 26, 2024

Hey @scanlonp,
thanks for checking the errors. Could you explain what destructive changes means here? Since i am trying to add this feature for more then a year now, it could be that things changed in the meantime. When i created this feature and testet, i could not see destructive changes

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Aug 16, 2024
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(pipelines): (Add feature to display all changesets for stage before manual approval step)
3 participants