Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(synthetics): add nodejs puppeteer 8 runtime #30851

Merged
merged 4 commits into from
Jul 18, 2024
Merged

chore(synthetics): add nodejs puppeteer 8 runtime #30851

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
94c349c
feat: add nodejs puppeter 8 runtime
mazyu36 Jul 15, 2024
6db5212
fix unit test and integ test
mazyu36 Jul 17, 2024
31db06a
Merge branch 'main' into synthetics-node-puppeteer8
mazyu36 Jul 17, 2024
0f4cac7
Merge branch 'main' into synthetics-node-puppeteer8
mergify[bot] Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion packages/aws-cdk-lib/aws-synthetics/lib/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ export class Runtime {
* - **Ephemeral storage monitoring**: This runtime adds ephemeral storage monitoring in customer accounts.
* - **Bug fixes**
*
* @see https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Library_nodejs_puppeteer.html#CloudWatch_Synthetics_runtimeversion-nodejs-puppeteer-6.1
* @see https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Library_nodejs_puppeteer.html#CloudWatch_Synthetics_runtimeversion-nodejs-puppeteer-6.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this change, although necessary, may get hidden in history because it is being done with addition of Node.js puppeteer 8 runtime, hence, is it possible to take this separately (if not much effort required)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChakshuGupta13
Thanks.
I've separated a PR #30853 to fix wrong link.

*/
public static readonly SYNTHETICS_NODEJS_PUPPETEER_6_2 = new Runtime('syn-nodejs-puppeteer-6.2', RuntimeFamily.NODEJS);

Expand All @@ -207,6 +207,20 @@ export class Runtime {
*/
public static readonly SYNTHETICS_NODEJS_PUPPETEER_7_0 = new Runtime('syn-nodejs-puppeteer-7.0', RuntimeFamily.NODEJS);

/**
* `syn-nodejs-puppeteer-8.0` includes the following:
* - Lambda runtime Node.js 20.x
* - Puppeteer-core version 22.10.0
* - Chromium version 125.0.6422.112
*
* New Features:
* - **Support for two-factor authentication**
* - **Bug fixes** for situations where some service clients were losing data in Node.js SDK V3 responses.
*
* @see https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Library_nodejs_puppeteer.html#CloudWatch_Synthetics_runtimeversion-nodejs-puppeteer-8.0
*/
public static readonly SYNTHETICS_NODEJS_PUPPETEER_8_0 = new Runtime('syn-nodejs-puppeteer-8.0', RuntimeFamily.NODEJS);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will it not be better to have test(s) which utilise this enum for successful synthesis?
(note: not sure if it is possible to add such a test)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChakshuGupta13
Thanks.
I've added a unit test and an integ test to verify deploying new runtime Canary.


/**
* `syn-python-selenium-1.0` includes the following:
* - Lambda runtime Python 3.8
Expand Down