Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codepipeline-actions): set service as backing resource for EcsDeployAction #3085

Merged
merged 2 commits into from
Jun 27, 2019
Merged

fix(codepipeline-actions): set service as backing resource for EcsDeployAction #3085

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7850b93
fix(codepipeline-actions): set service as backing resource for EcsDep…
strax Jun 26, 2019
83c2d4f
Merge branch 'master' into strax/cross-account-ecs-deploy-action
Jun 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/@aws-cdk/aws-codepipeline-actions/lib/ecs/deploy-action.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ export class EcsDeployAction extends Action {
provider: 'ECS',
artifactBounds: deployArtifactBounds(),
inputs: [determineInputArtifact(props)],
resource: props.service
});

this.props = props;
Expand Down
15 changes: 15 additions & 0 deletions packages/@aws-cdk/aws-codepipeline-actions/test/ecs/test.ecs-deploy-action.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,21 @@ export = {

test.done();
},

"sets the target service as the action's backing resource"(test: Test) {
const service = anyEcsService();
const artifact = new codepipeline.Artifact('Artifact');

const action = new cpactions.EcsDeployAction({
actionName: 'ECS',
service,
input: artifact
});

test.equal(action.actionProperties.resource, service);

test.done();
},
},
};

Expand Down