-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fsx): construct for NetApp ONTAP file system #30849
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Switches to open-constructs/aws-cdk-library#42 |
This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #30848.
Reason for this change
There is no construct for creating FSx for NetApp ONTAP file system.
Description of changes
ontap-file-system.ts
OntapFileSystem
classOntapFileSystemProps
interfacemaintenance-time.ts
MaintenanceTime
class for not only ONTAP file system but all file systemsThe creation of SVMs and Volumes is not included in this PR.
In the future, I think it would be good to add methods like
fileSystem.addSvm()
.Description of how you validated changes
Added both unit and integ tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license