feat(sns): add delivery policy to sns subscriptions #30830
Conversation
github-actions
bot
added
the
beginning-contributor
github-actions
bot
added
effort/small
| * Algorithms which can be used by SNS to calculate the delays associated with all of the retry attempts between the first and last retries in the backoff phase. | ||
| */ | ||
| export enum BackoffFunction { | ||
| /** Arithmetic. |
There was a problem hiding this comment.
Not the best doc I've ever written 😅 , the best indicator of to what these each of these do that I found was an image at the very bottom of the doc page here: https://docs.aws.amazon.com/sns/latest/dg/sns-message-delivery-retries.html - suggestions welcome.
| /** The minimum delay for a retry (in seconds). Must be at least 1 and not exceed `maxDelayTarget`. | ||
| * @default 20 | ||
| */ | ||
| readonly minDelayTarget: number; |
There was a problem hiding this comment.
Only, this and the next two appear to be mandatory if healthyRetryPolicy is specified, thought I can't find any specific doc for this.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-community-review
|
Hi This PR has been pending for community review for a while. Please consider posting it on the #contributing channel in cdk.dev. Community members will be on the lookout there as well for possible reviews. Check How to get your P2 PR community reviewed for more details. |
|
Thanks, I've posted on the channel. |
Issue # (if applicable)
Closes #17576.
Reason for this change
To allow setting of delivery policy for appropriate sns subscriptions.
Description of changes
Subscriptions can now take a new parameter
deliveryPolicywhich consists of ahealthyRetryPolicy, athrottlePolicy, and arequestPolicy(each having the same parameters described here: https://docs.aws.amazon.com/sns/latest/dg/sns-message-delivery-retries.html#creating-delivery-policy).Description of how you validated changes
New integration test along with unit tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license