Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eks): added support for bootstrapSelfManagedAddons #30804

Closed
wants to merge 14 commits into from

Conversation

mrlikl
Copy link
Contributor

@mrlikl mrlikl commented Jul 9, 2024

Issue # (if applicable)

Closes #30792

Reason for this change

The feature enables support to create clusters without the default networking add-ons

Description of changes

Added the prop bootstrapSelfManagedAddons to the cluster and incremented the eks client version

Description of how you validated changes

Created a cluster and updated the cluster with the prop bootstrapSelfManagedAddons, ideally it has to be replaced if the value changes, this is at par with the CFN behaviour

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK feature-request A feature should be added or improved. p2 labels Jul 9, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team July 9, 2024 20:51
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@mrlikl
Copy link
Contributor Author

mrlikl commented Jul 9, 2024

This is WIP, the default version available in Lambda (used by the cluster resource handler) is using a lower version of SDK ~ 3.552.0, hence the prop is being avoided.

@mrlikl mrlikl changed the title feat(aws-eks): added support for bootstrapSelfManagedAddons feat(eks): added support for bootstrapSelfManagedAddons Jul 9, 2024
@github-actions github-actions bot added the effort/small Small work item – less than a day of effort label Jul 10, 2024
@mrlikl
Copy link
Contributor Author

mrlikl commented Jul 10, 2024

The reason for renaming integ.eks-helm-asset to integ.eks-helm-chart is that, the existing test had two releases with the same name rds-chart-release, when the stack is deployed as a whole, it would fail with the error Error: release: already exist, and just changing the release name was not solving the issue. As the existing stack was deployed first. Hence renamed and fixed the issues on the test.

@aws-cdk-automation aws-cdk-automation dismissed their stale review July 10, 2024 11:50

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 15, 2024
@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

1 similar comment
@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 4feca1b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

1 similar comment
@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Sep 1, 2024
Copy link

github-actions bot commented Sep 1, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-eks): Support for BootstrapSelfManagedAddons while creating the cluster
2 participants