feat(stepfunctions-tasks): support FLEX execution class for GlueStartJobRun #30534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
feature-request
aws-cdk-automation
added
the
pr/needs-community-review
lpizzinidev
approved these changes
Jun 13, 2024
packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/glue/start-job-run.ts
Outdated
Show resolved
Hide resolved
|
|
||
| /** | ||
| * Each worker maps to 0.25 DPU (2 vCPU, 4 GB of memory, 64 GB disk), and provides 1 executor per worker. Suitable for low volume streaming jobs. | ||
| */ | ||
| G_025X ='G.025X', | ||
| G_025X = 'G.025X', |
There was a problem hiding this comment.
Can you please move G_025X between STANDARD and G_1X?
It seems a bit out of place here.
There was a problem hiding this comment.
@lpizzinidev
Thanks. I've changed the order.
aws-cdk-automation
added
pr/needs-maintainer-review
…b-run.ts Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
GavinZZ
approved these changes
Jun 18, 2024
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@Mergifyio update |
✅ Branch has been successfully updated |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
sarangarav
pushed a commit
to sarangarav/aws-cdk
that referenced
this pull request
Jun 21, 2024
…JobRun (aws#30534) ### Issue # (if applicable) Closes aws#30533 ### Reason for this change To support `FLEX` execution class for `GlusStartJobRun`. By using `FLEX` class, you can reduce the cost of running Glue job. ### Description of changes Add `execution class` to the `GlusStartJobRun` class. ### Description of how you validated changes Add unit tests and integ tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mazyu36
added a commit
to mazyu36/aws-cdk
that referenced
this pull request
Jun 22, 2024
…JobRun (aws#30534) ### Issue # (if applicable) Closes aws#30533 ### Reason for this change To support `FLEX` execution class for `GlusStartJobRun`. By using `FLEX` class, you can reduce the cost of running Glue job. ### Description of changes Add `execution class` to the `GlusStartJobRun` class. ### Description of how you validated changes Add unit tests and integ tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced Jul 12, 2024
This was referenced Jul 19, 2024
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #30533
Reason for this change
To support
FLEXexecution class forGlusStartJobRun.By using
FLEXclass, you can reduce the cost of running Glue job.Description of changes
Add
execution classto theGlusStartJobRunclass.Description of how you validated changes
Add unit tests and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license