Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3-notifications): unable to delete the existing S3 event notifications (under feature flag) #30527

Closed
wants to merge 28 commits into from
Closed

fix(s3-notifications): unable to delete the existing S3 event notifications (under feature flag) #30527

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
e009a07
Bug fix to address the issues deleting existing S3 event notifications
Jun 11, 2024
8654722
Merge branch 'aws:main' into feature/s3-event-notifications
sarangarav Jun 13, 2024
51d21d8
Bug fix to address the issues deleting existing S3 event notifications
Jun 13, 2024
6fadc7b
chore(release): 2.146.0
Jun 13, 2024
94d71d1
chore: update changelog
scanlonp Jun 13, 2024
d6b9a3c
fix(stepfunctions): add docs and warning DistributedMap Class ignores…
mazyu36 Jun 13, 2024
49d9f8d
chore(roadmap): team roadmap update (#30553)
adamjkeller Jun 14, 2024
dcb02c2
feat(ec2): add nitro enclave and hibernation settings to the Instance…
mazyu36 Jun 14, 2024
0c16a3c
feat: update L1 CloudFormation resource definitions (#30569)
aws-cdk-automation Jun 17, 2024
5c65250
feat(s3): allow user to set Log Group on S3 Bucket autoDeleteObjects …
samson-keung Jun 17, 2024
9c6bf72
fix(custom-resource-handlers): don't recursively process s3 bucket ob…
isker Jun 17, 2024
85f07bb
fix(core): overrideLogicalId validation (#29708)
nmussy Jun 17, 2024
5d1fb75
feat(ses): allow VDM settings at the configuration set level (#30051)
mazyu36 Jun 18, 2024
dfe40f4
chore(rds): add MariaDB version 10.4.34, 10.5.25, 10.6.18, 10.11.8 (#…
mazyu36 Jun 18, 2024
d82fe4d
fix(globalaccelerator-endpoints): add preserveClientIp option for net…
SaschaJanssen Jun 18, 2024
8f99591
fix(apigateway): remove timeout upper bound max (#30547)
nmussy Jun 18, 2024
cc27aba
revert: "feat(s3): allow user to set Log Group on S3 Bucket autoDelet…
TheRealAmazonKendra Jun 19, 2024
e84e4dc
chore(eks): set AWS_STS_REGIONAL_ENDPOINTS to regional for KubectlFun…
pahud Jun 19, 2024
9011bab
chore(codebuild): add new CodeBuild lambda dotnet8 compute images (#3…
RationalKuma4 Jun 19, 2024
9caa7b3
feat(stepfunctions-tasks): support FLEX execution class for GlueStart…
mazyu36 Jun 20, 2024
a330faf
chore(release): 2.147.0
Jun 20, 2024
c7c698e
Update CHANGELOG.v2.md
moelasmar Jun 20, 2024
7f871b6
feat(codebuild): adding `project.visibility` (#30103)
watany-dev Jun 20, 2024
486c3c0
feat(cognito): add defaultRedirectUri to UserPoolClient (#30481)
mazyu36 Jun 21, 2024
279065a
feat(apprunner): add AutoScalingConfiguration for AppRunner Service (…
mazyu36 Jun 21, 2024
ca381f7
chore(ec2): choose NAT instance v2 machineImage cpuType automatically…
tmokmss Jun 21, 2024
8ccc4b3
feat(pipes-enrichments): add Step Functions enrichment eventbridge pi…
mazyu36 Jun 21, 2024
1b43806
Bug fix to address the issues deleting existing S3 event notifications
Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...teg.kinesis-at-timestamp.js.snapshot/lambda-event-source-kinesis-at-timestamp.assets.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions ...g.kinesis-at-timestamp.js.snapshot/lambda-event-source-kinesis-at-timestamp.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,7 @@
}
]
}
},
"UpdateReplacePolicy": "Retain",
"DeletionPolicy": "Retain"
}
}
},
"Conditions": {
Expand Down
2 changes: 1 addition & 1 deletion ...g/test/aws-lambda-event-sources/test/integ.kinesis-at-timestamp.js.snapshot/manifest.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ...mbda-event-sources/test/integ.kinesis.js.snapshot/lambda-event-source-kinesis.assets.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions ...da-event-sources/test/integ.kinesis.js.snapshot/lambda-event-source-kinesis.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,7 @@
}
]
}
},
"UpdateReplacePolicy": "Retain",
"DeletionPolicy": "Retain"
}
}
},
"Conditions": {
Expand Down
2 changes: 1 addition & 1 deletion ...ramework-integ/test/aws-lambda-event-sources/test/integ.kinesis.js.snapshot/manifest.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ...es/test/integ.kinesiswithdlq.js.snapshot/lambda-event-source-kinesis-with-dlq.assets.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions .../test/integ.kinesiswithdlq.js.snapshot/lambda-event-source-kinesis-with-dlq.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,9 +144,7 @@
}
]
}
},
"UpdateReplacePolicy": "Retain",
"DeletionPolicy": "Retain"
}
},
"Q63C6E3AB": {
"Type": "AWS::SQS::Queue",
Expand Down
2 changes: 1 addition & 1 deletion ...k-integ/test/aws-lambda-event-sources/test/integ.kinesiswithdlq.js.snapshot/manifest.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions ....snapshot/asset.2ec8ad9e91dcd6e7ad6a5c84ffc6c9c05c408aca3b26ceb2816d81043e6c4dc3/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion ....snapshot/asset.96ea260348625427bb7f28ab3b379f62da6f428bcd155cb13f9261aa6a404b0d/index.js
View file
Open in desktop

This file was deleted.

10 changes: 5 additions & 5 deletions ...es/test/integ.s3-onfailuire-destination.js.snapshot/lambda-event-source-s3ofd.assets.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

121 changes: 2 additions & 119 deletions .../test/integ.s3-onfailuire-destination.js.snapshot/lambda-event-source-s3ofd.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@
"S3Bucket": {
"Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}"
},
"S3Key": "96ea260348625427bb7f28ab3b379f62da6f428bcd155cb13f9261aa6a404b0d.zip"
"S3Key": "2ec8ad9e91dcd6e7ad6a5c84ffc6c9c05c408aca3b26ceb2816d81043e6c4dc3.zip"
},
"Timeout": 900,
"MemorySize": 128,
Expand All @@ -308,15 +308,7 @@
"Arn"
]
},
"Runtime": {
"Fn::FindInMap": [
"LatestNodeRuntimeMap",
{
"Ref": "AWS::Region"
},
"value"
]
},
"Runtime": "nodejs18.x",
"Description": {
"Fn::Join": [
"",
Expand All @@ -335,115 +327,6 @@
]
}
},
"Mappings": {
"LatestNodeRuntimeMap": {
"af-south-1": {
"value": "nodejs20.x"
},
"ap-east-1": {
"value": "nodejs20.x"
},
"ap-northeast-1": {
"value": "nodejs20.x"
},
"ap-northeast-2": {
"value": "nodejs20.x"
},
"ap-northeast-3": {
"value": "nodejs20.x"
},
"ap-south-1": {
"value": "nodejs20.x"
},
"ap-south-2": {
"value": "nodejs20.x"
},
"ap-southeast-1": {
"value": "nodejs20.x"
},
"ap-southeast-2": {
"value": "nodejs20.x"
},
"ap-southeast-3": {
"value": "nodejs20.x"
},
"ap-southeast-4": {
"value": "nodejs20.x"
},
"ca-central-1": {
"value": "nodejs20.x"
},
"cn-north-1": {
"value": "nodejs18.x"
},
"cn-northwest-1": {
"value": "nodejs18.x"
},
"eu-central-1": {
"value": "nodejs20.x"
},
"eu-central-2": {
"value": "nodejs20.x"
},
"eu-north-1": {
"value": "nodejs20.x"
},
"eu-south-1": {
"value": "nodejs20.x"
},
"eu-south-2": {
"value": "nodejs20.x"
},
"eu-west-1": {
"value": "nodejs20.x"
},
"eu-west-2": {
"value": "nodejs20.x"
},
"eu-west-3": {
"value": "nodejs20.x"
},
"il-central-1": {
"value": "nodejs20.x"
},
"me-central-1": {
"value": "nodejs20.x"
},
"me-south-1": {
"value": "nodejs20.x"
},
"sa-east-1": {
"value": "nodejs20.x"
},
"us-east-1": {
"value": "nodejs20.x"
},
"us-east-2": {
"value": "nodejs20.x"
},
"us-gov-east-1": {
"value": "nodejs18.x"
},
"us-gov-west-1": {
"value": "nodejs18.x"
},
"us-iso-east-1": {
"value": "nodejs18.x"
},
"us-iso-west-1": {
"value": "nodejs18.x"
},
"us-isob-east-1": {
"value": "nodejs18.x"
},
"us-west-1": {
"value": "nodejs20.x"
},
"us-west-2": {
"value": "nodejs20.x"
}
}
},
"Parameters": {
"BootstrapVersion": {
"Type": "AWS::SSM::Parameter::Value<String>",
Expand Down
8 changes: 1 addition & 7 deletions ...t/aws-lambda-event-sources/test/integ.s3-onfailuire-destination.js.snapshot/manifest.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading