feat(lambda): add domainName prop to FunctionUrl #30198
Closed
+50
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #23005.
Reason for this change
This change is to address this issue
Description of changes
This PR adds a new property called domainName to the FunctionUrl construct. The goal is to make it easy for customers to get the domain name directly (
FunctionUrl.domainName
) instead of first getting the url (FunctionUrl.url
) and then removing the scheme and the trailing slash.The README has been updated.
Description of how you validated changes
I Added some unit tests. I Don't think integration tests are necessary in this case.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license