Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rds): fix certificate enum values misspelling #30135

Merged
merged 4 commits into from
May 10, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
make adjustment for docdb
  • Loading branch information
scanlonp committed May 9, 2024
commit bfa8e14073f736df434dbd92e1e7a3df303d558e
Original file line number Diff line number Diff line change
@@ -17,7 +17,7 @@ new DatabaseCluster(stack, 'Database', {
password: SecretValue.unsafePlainText('7959866cacc02c2d243ecfe177464fe6'),
},
instanceType: instanceType,
caCertificate: CaCertificate.RDS_CA_RDS4096_G1,
caCertificate: CaCertificate.RDS_CA_RSA4096_G1,
vpcSubnets: { subnetType: SubnetType.PUBLIC },
vpc,
removalPolicy: RemovalPolicy.DESTROY,
2 changes: 1 addition & 1 deletion packages/aws-cdk-lib/aws-docdb/README.md
Original file line number Diff line number Diff line change
@@ -255,6 +255,6 @@ const cluster = new docdb.DatabaseCluster(this, 'Database', {
subnetType: ec2.SubnetType.PUBLIC,
},
vpc,
caCertificate: docdb.CaCertificate.RDS_CA_RDS4096_G1, // CA certificate for all instances under this cluster
caCertificate: docdb.CaCertificate.RDS_CA_RSA4096_G1, // CA certificate for all instances under this cluster
});
```
2 changes: 1 addition & 1 deletion packages/aws-cdk-lib/aws-docdb/test/cluster.test.ts
Original file line number Diff line number Diff line change
@@ -86,7 +86,7 @@ describe('DatabaseCluster', () => {
password: cdk.SecretValue.unsafePlainText('tooshort'),
},
instanceType: ec2.InstanceType.of(ec2.InstanceClass.BURSTABLE2, ec2.InstanceSize.SMALL),
caCertificate: CaCertificate.RDS_CA_RDS4096_G1,
caCertificate: CaCertificate.RDS_CA_RSA4096_G1,
vpc,
});

2 changes: 1 addition & 1 deletion packages/aws-cdk-lib/aws-docdb/test/instance.test.ts
Original file line number Diff line number Diff line change
@@ -66,7 +66,7 @@ describe('DatabaseInstance', () => {
new DatabaseInstance(stack, 'Instance', {
cluster: stack.cluster,
instanceType: SINGLE_INSTANCE_TYPE,
caCertificate: CaCertificate.RDS_CA_RDS4096_G1,
caCertificate: CaCertificate.RDS_CA_RSA4096_G1,
});

// THEN