Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): use "string" for physical name props #3011

Merged
merged 9 commits into from
Jun 23, 2019
Merged

refactor(core): use "string" for physical name props #3011

merged 9 commits into from
Jun 23, 2019

Commits on Jun 23, 2019

  1. refactor(core): use "string" for physical name props 

    Instead of a `PhysicalName` type, use `string` to represent
physical names in resource props, and offer a marker `PhysicalName.GENERATE_IF_NEEDED`
to let users indicate that they allow cross-environment usage.
    Elad Ben-Israel committed Jun 23, 2019
    Configuration menu
    Copy the full SHA
    5daa4fa View commit details
    Browse the repository at this point in the history

  2. change awslint rule for physical names to require strings

    Elad Ben-Israel committed Jun 23, 2019
    Configuration menu
    Copy the full SHA
    d54e715 View commit details
    Browse the repository at this point in the history

  3. change protected api

    Elad Ben-Israel committed Jun 23, 2019
    Configuration menu
    Copy the full SHA
    d6a6e43 View commit details
    Browse the repository at this point in the history

  4. improve some comments/docs/errors

    Elad Ben-Israel committed Jun 23, 2019
    Configuration menu
    Copy the full SHA
    f777db5 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/master' into benisrae/physical-n… 

    …ames-as-strings
    Elad Ben-Israel committed Jun 23, 2019
    Configuration menu
    Copy the full SHA
    9d9ff92 View commit details
    Browse the repository at this point in the history

  6. unreferenced import

    Elad Ben-Israel committed Jun 23, 2019
    Configuration menu
    Copy the full SHA
    f086baf View commit details
    Browse the repository at this point in the history

  7. physical name does not require dereference anymore

    Elad Ben-Israel committed Jun 23, 2019
    Configuration menu
    Copy the full SHA
    84e4a0d View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/master' into benisrae/physical-n… 

    …ames-as-strings
    Elad Ben-Israel committed Jun 23, 2019
    Configuration menu
    Copy the full SHA
    ef0c3f9 View commit details
    Browse the repository at this point in the history

  9. fix build break

    Elad Ben-Israel committed Jun 23, 2019
    Configuration menu
    Copy the full SHA
    159ce25 View commit details
    Browse the repository at this point in the history