Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: align all versions of typescript, jsii & jsii-rosetta to 5.4 #29974

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Apr 26, 2024

Reason for this change

There were a number of inconsistencies with the versions used for typescript, jsii & jsii-rosetta in this repository.
Also the automated updater was incorrectly updating jsii minor versions.

I did some digging and turns out because jsii was at 5.4.x already, we are already using TypeScript 5.4 for most critical paths. So I went ahead and aligned all TS version on that.

Description of changes

Manually align all versions of typescript, jsii & jsii-rosetta.
Fixed the update workflow to only update patch version for these three packages.

Includes changes from #29978 until that is merged, and this PR is rebased.

Description of how you validated changes

Run through the test pipeline.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team April 26, 2024 08:56
@github-actions github-actions bot added the p2 label Apr 26, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 26, 2024
@@ -28,7 +28,6 @@
"jsii-diff": "1.97.0",
"jsii-pacmak": "1.97.0",
"jsii-reflect": "1.97.0",
"jsii-rosetta": "~5.4.2",
Copy link
Contributor Author

@mrgrain mrgrain Apr 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to cdk-build-tools as centralized place for jsii stuff. This is where the only jsii dependency was before as well.

@mrgrain mrgrain force-pushed the mrgrain/chore/align-jsii-ts-versions branch from f08fb76 to 34e1648 Compare April 26, 2024 16:36
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 26, 2024
@mrgrain mrgrain force-pushed the mrgrain/chore/align-jsii-ts-versions branch from 34e1648 to f2910a8 Compare April 26, 2024 17:33
@mrgrain mrgrain changed the title chore: align all versions of typescript, jsii & jsii-rosetta chore: align all versions of typescript, jsii & jsii-rosetta to 5.4 Apr 26, 2024
@mrgrain mrgrain force-pushed the mrgrain/chore/align-jsii-ts-versions branch from f2910a8 to b514eb7 Compare April 26, 2024 20:32
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b514eb7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@colifran colifran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 26, 2024
Copy link
Contributor

mergify bot commented Apr 26, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 28052aa into main Apr 26, 2024
17 checks passed
@mergify mergify bot deleted the mrgrain/chore/align-jsii-ts-versions branch April 26, 2024 21:13
Copy link
Contributor

mergify bot commented Apr 26, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

This was referenced Apr 29, 2024
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants