-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(appsync): add Enhanced Monitoring #29940
feat(appsync): add Enhanced Monitoring #29940
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Exemption Request I don't think it is worth adding integration test for this one - it just adds missing property to L2 construct. |
…c-enhanced-metrics
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing ✅ A exemption request has been requested. Please wait for a maintainer's review. |
Issue
Closes #29933.
Reason for this change
AppSync team lately added feature to allow for more granular metrics for AppSync. It was incorporated to the AWS CloudFormation, but not yet to the AWS CDK.
Description of changes
I've added ENUMs for new values. Added everything connected with Enhanced Monitoring on Data Sources, Resolver & GraphQL API level. Also added paragraph into the documentation describing the feature.
Description of how you validated changes
Added unit tests for Data Sources, Resolver & GraphQL API. All passes.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license