Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Prevent volatile physical name generation #2984

Merged
merged 7 commits into from
Jul 2, 2019
Merged

fix(core): Prevent volatile physical name generation #2984

merged 7 commits into from
Jul 2, 2019

Commits on Jun 21, 2019

  1. fix(core): Prevent volatile physical name generation 

    The PhysicalName generation strategy for cross-account/region use-cases
could generate names that are subject to collisions/sniping when the
account and region were not specified; and those names would also have
changed if a stack went from re-locatable to account/region specific,
even if the target environment would not have changed.

The generator will now throw errors in case the account ID or region is
blank or a Token.
    @RomainMuller
    RomainMuller committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    611e001 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2019

  1. Merge remote-tracking branch 'origin/master' into rmuller/physical-names

    @RomainMuller
    RomainMuller committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    43b106a View commit details
    Browse the repository at this point in the history

  2. Add test

    @RomainMuller
    RomainMuller committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    9ff4304 View commit details
    Browse the repository at this point in the history

  3. Fix test

    @RomainMuller
    RomainMuller committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    e1afab6 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2019

  1. Merge branch 'master' into rmuller/physical-names

    @RomainMuller
    RomainMuller committed Jul 2, 2019
    Configuration menu
    Copy the full SHA
    cdaf16d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into rmuller/physical-names

    @RomainMuller
    RomainMuller committed Jul 2, 2019
    Configuration menu
    Copy the full SHA
    34f4ad9 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into rmuller/physical-names

    @RomainMuller
    RomainMuller committed Jul 2, 2019
    Configuration menu
    Copy the full SHA
    e14c611 View commit details
    Browse the repository at this point in the history