Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ecs): streamline the term "service discovery" to "AWS CloudM… #2979

Merged
merged 2 commits into from
Jun 21, 2019
Merged

refactor(ecs): streamline the term "service discovery" to "AWS CloudM… #2979

merged 2 commits into from
Jun 21, 2019

Conversation

hencrice
Copy link
Contributor

…ap" so that they are consistent

Closes #2978.

Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • [N/A] Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@hencrice hencrice requested review from SoManyHs and a team as code owners June 21, 2019 00:50
piradeepk
piradeepk approved these changes Jun 21, 2019
View reviewed changes
Copy link
Contributor

@piradeepk piradeepk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@piradeepk
Copy link
Contributor

@rix0rrr @eladb can you please review/merge?

eladb
eladb previously requested changes Jun 21, 2019
View reviewed changes
packages/@aws-cdk/aws-ecs/lib/base/base-service.ts Outdated
@@ -72,7 +72,7 @@ export interface BaseServiceProps {
*
* @default - AWS Cloud Map service discovery is not enabled.
*/
readonly serviceDiscoveryOptions?: ServiceDiscoveryOptions;
readonly awsCloudMapOptions?: AWSCloudMapOptions;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the aws prefix from both prop and type names. We also usually prefer to avoid the “options” postfix from the prop name (it’s good on the type), so this should be:

cloudMap: CloudMapOptions

@rix0rrr rix0rrr self-assigned this Jun 21, 2019
@rix0rrr rix0rrr merged commit db981bf into aws:master Jun 21, 2019
@hencrice hencrice deleted the hencrice/servicediscovery-to-cloudmap branch June 21, 2019 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

@piradeepk piradeepk piradeepk approved these changes

@eladb eladb eladb left review comments

@SoManyHs SoManyHs Awaiting requested review from SoManyHs

Assignees

@rix0rrr rix0rrr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ecs: streamline the term "service discovery" to "AWS CloudMap"
4 participants
@hencrice @piradeepk @rix0rrr @eladb