Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rds): improve error messages for providing a vpc to cluster #29706

Merged
merged 7 commits into from
Apr 17, 2024
Merged

chore(rds): improve error messages for providing a vpc to cluster #29706

merged 7 commits into from
Apr 17, 2024

Commits on Apr 3, 2024

  1. Update cluster.ts 

    Just an idea/I was curious. Why do we have separate error messages here vs just using the same error message?

Personally, when I stumbled upon this error I got a bit confused. But I really like the top error message of 'Provide either vpc or instanceProps.vpc, but not both"
    @prasanthlouis
    prasanthlouis committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    4e2e5fe View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Update cluster.test.ts

    @prasanthlouis
    prasanthlouis committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    f8bb08f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into patch-3

    @prasanthlouis
    prasanthlouis committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    023948a View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Merge branch 'main' into patch-3

    @prasanthlouis
    prasanthlouis committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    d1056f5 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Merge branch 'main' into patch-3

    @prasanthlouis
    prasanthlouis committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    5690759 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Merge branch 'main' into patch-3

    @prasanthlouis
    prasanthlouis committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    0764832 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Merge branch 'main' into patch-3

    @mergify
    mergify[bot] committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    bea4d2f View commit details
    Browse the repository at this point in the history