chore(route53): support new partitions in route53 cross-account delegator #29537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
beginning-contributor
aaythapa
reviewed
Mar 21, 2024
There was a problem hiding this comment.
Thanks for making this change! I see that this got combined with your other change. Could you take that out and only keep the change to add new partitions?
aws-cdk-automation
added
the
pr/needs-community-review
aaythapa
reviewed
Mar 22, 2024
...-cdk/custom-resource-handlers/lib/aws-route53/cross-account-zone-delegation-handler/index.ts
Outdated
Show resolved
Hide resolved
aaythapa
approved these changes
Mar 22, 2024
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
1 task
ahammond
pushed a commit
to ahammond/aws-cdk
that referenced
this pull request
Mar 26, 2024
…ator (aws#29537) ### Issue # (if applicable) n/a ### Reason for this change Support new partitions from the AWS JS SDK: https://github.com/aws/aws-sdk-js-v3/blob/05c32e74595113347211ba0584197b665ebab1db/packages/util-endpoints/src/lib/aws/partitions.json#L190-L2 ### Description of changes Support new partitions from the AWS JS SDK: https://github.com/aws/aws-sdk-js-v3/blob/05c32e74595113347211ba0584197b665ebab1db/packages/util-endpoints/src/lib/aws/partitions.json#L190-L214 ### Description of how you validated changes This is a minor update to a mapping that has no existing unit tests. I'm happy to add if desired, but likely unnecessary. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
n/a
Reason for this change
Support new partitions from the AWS JS SDK: https://github.com/aws/aws-sdk-js-v3/blob/05c32e74595113347211ba0584197b665ebab1db/packages/util-endpoints/src/lib/aws/partitions.json#L190-L2
Description of changes
Support new partitions from the AWS JS SDK: https://github.com/aws/aws-sdk-js-v3/blob/05c32e74595113347211ba0584197b665ebab1db/packages/util-endpoints/src/lib/aws/partitions.json#L190-L214
Description of how you validated changes
This is a minor update to a mapping that has no existing unit tests. I'm happy to add if desired, but likely unnecessary.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license