Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): support optimistic stabilization strategy(--exit-on-config-complete) #29536
feat(cli): support optimistic stabilization strategy(--exit-on-config-complete) #29536
Changes from 5 commits
a78b102
34afe01
e00c0fa
8dbc5c3
4426221
f721596
d9a4c13
5d488c0
0311661
86abf37
ad261c8
de245f0
30ee9b0
579dff4
caaf9f7
33fd364
6209ce5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it make sense to also add an option for
cdk watch
??There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct me if I am wrong but AFAIK
cdk watch
essentially monitors a stack and update it through SDK calls without redeploying it. I thinkcdk watch
would not monitor the stack status so I can't see how this would fit in this scenario. I might be wrong though.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I thinkk we're both right. It's an options to turn off the --hot-swap for
watch
https://docs.aws.amazon.com/cdk/v2/guide/cli.html#cli-deploy.This comment is just a suggestion, though. I would approve this PR with or without watch support, since that could be added in the future, if there was a demand for it