docs(events): mention property requirements when creating custom events #29287
Conversation
github-actions
bot
added
p2
beginning-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
evzzk
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
@mergify update |
✅ Branch has been successfully updated |
GavinZZ
dismissed
MrArnoldPalmer’s stale review
Dismissing as the comments are addressed. Merging this PR.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify
bot
dismissed stale reviews from rix0rrr and GavinZZ
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-community-review
|
@mergify merge |
❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚. |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚. |
❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚. |
aws-cdk-automation
removed
the
pr/needs-community-review
❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚. |
1 similar comment
❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚. |
Issue # (if applicable)
Closes #.
Reason for this change
When creating an EventPattern for a custom event, a few properties are required. Documentation currently isn't clear on which properties are required. This change links to AWS documentation that describes the required properties for custom events.
Description of changes
Added text stating that some optional properties are required for custom events and provided link to docs.
Description of how you validated changes
No validation
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license