-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stepfunctions): support Map ItemSelector #28771
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple nits + you should use assertions in the integ test. Otherwise looks good to me!
packages/@aws-cdk-testing/framework-integ/test/aws-stepfunctions/test/integ.map-itemselector.ts
Show resolved
Hide resolved
packages/@aws-cdk-testing/framework-integ/test/aws-stepfunctions/test/integ.map-itemselector.ts
Outdated
Show resolved
Hide resolved
* @see | ||
* https://docs.aws.amazon.com/step-functions/latest/dg/input-output-itemselector.html | ||
* | ||
* @default $ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does $ have a significance as a default? Can this docstring be descriptive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$
represents the entire state input in Step Functions. Because this is essentially a replacement of parameters
, I kept the docstring the same as what it was for parameters
.
Pull request has been modified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good addition! Thanks!
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Adds support for Map's ItemSelector field and deprecates parameters.
With the release of Distributed Maps, AWS StepFunctions has released a few new fields, and deprecated two old ones for Map states. One of them was
Iterator
which was replaced withItemProcessor
, the other one isParameters
(replaced byItemSelector
). A similar PR was made to deprecateIterator
(#27913). While they are deprecated, these fields are still supported (PR reflects that)ItemProcessor
andItemSelector
are both fields that are supported inDISTRIBUTED
andINLINE
mode, hence why they were added to the existing Map constructCloses #23265
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license