Commits on Jun 13, 2019

1. fix(cloudformation-diff): string.replace error on cdk context (#2854) …

   `@aws-sdk/cloudformation-diff` depended on version `^2.1.1` of the `string-width`
   library in `v0.28.0` of `aws-sdk`. In `v0.29.0`, the dependency was bumped to
   `^4.1.0`, which inadvertently broke the `cdk context` command as reported
   in: #2854.
   
   The current version of `string-width` executes a [string replacement](sindresorhus/string-width@0bc308a#diff-168726dbe96b3ce427e7fedce31bb0bcR7), which ends up failing
   when a non-string (such as the `int` row numbers of the `cdk context`
   values). This did not previously occur, as the typecheck for `string`
   would cause the function to return early and report zero-length.
   
   The easiest solution here is to cast these values to `string`, which
   has the beneficial side effect of ensuring that their character lengths
   are taken into consideration rather than being defaulted to `0` as they
   had previously been.

   

   michaelmoussa committed Jun 13, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for 30f0912
   • Browse repository at this point

   Copy the full SHA

   30f0912 View commit details

   Browse the repository at this point in the history