Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Introduced Duration class #2857

Merged
merged 8 commits into from
Jun 20, 2019
Merged

feat(core): Introduced Duration class #2857

merged 8 commits into from
Jun 20, 2019

Commits on Jun 13, 2019

  1. feat(core): Introduced Duration class

    This can be used to model durations in a user-friendly way, while
    allowing coercion into the desired/required time unit at the usage site.
    
    There is now a default requirement that properties exposed by the APIs
    and that have a duration-like name (ending in `duration`, `period`,
    `timeout` or `ttl`) have a type of `@aws-cdk/cdk.Duration` and do not
    contain a unit suffix (`Days`, `Millis`, `Seconds`, `Sec`, ...).
    
    BREAKING CHANGE: Properties throughout the AWS Construct Libraries that
                     represent lengths of time have been re-typed to be
                     `@aws-cdk/cdk.Duration` instead of `number`, and were
                     renamed to exclude any unit indication.
    RomainMuller committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    56d64eb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    910e652 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2019

  1. Configuration menu
    Copy the full SHA
    f9c1ee9 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2019

  1. Stop the switch madness!

    RomainMuller committed Jun 18, 2019
    Configuration menu
    Copy the full SHA
    5f9ca7a View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2019

  1. PR Feedback

    1. Dropped the free-floating toSeconds function
    2. Added test for unresolved tokens in constructor
    3. Made .toString() return a breaking token.
    RomainMuller committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    d1ef198 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dfdd3a3 View commit details
    Browse the repository at this point in the history
  3. Last feedback

    RomainMuller committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    f6d890a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    91dc951 View commit details
    Browse the repository at this point in the history