Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appsync): use logretention to always create a log group #28527

Closed
wants to merge 5 commits into from
Closed

fix(appsync): use logretention to always create a log group #28527

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5ad1af7
Use LogRetention to always create a log group
mrlikl Dec 29, 2023
c77e9ad
Modified tests to take log into consideration
mrlikl Dec 29, 2023
68a1b81
re-run existing integ tests in appsync
mrlikl Dec 30, 2023
d9b926f
added a new integ test
mrlikl Dec 30, 2023
204ed20
Merge branch 'aws:main' into graphql-api-logs
mrlikl Dec 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions packages/aws-cdk-lib/aws-appsync/lib/graphqlapi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,14 +707,12 @@ export class GraphqlApi extends GraphqlApiBase {

const logGroupName = `/aws/appsync/apis/${this.apiId}`;

this.logGroup = LogGroup.fromLogGroupName(this, 'LogGroup', logGroupName);
const logRetention = new LogRetention(this, 'LogRetention', {
logGroupName: logGroupName,
retention: props.logConfig?.retention ?? RetentionDays.INFINITE,
});

if (props.logConfig?.retention) {
new LogRetention(this, 'LogRetention', {
logGroupName: this.logGroup.logGroupName,
retention: props.logConfig.retention,
});
};
this.logGroup = LogGroup.fromLogGroupArn(this, 'LogGroup', logRetention.logGroupArn);
}

private setupSourceApiAssociations() {
Expand Down
Loading