refactor(events): clean up Events APIs #2840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 12, 2019 14:52
Biggest change is modeling the schedule types. BREAKING CHANGE: * **events**: `EventPattern.detail` is now a map. * **events**: `scheduleExpression: string` is now `schedule: Schedule`.
eladb
reviewed
Jun 13, 2019
| @@ -26,7 +27,7 @@ class EventStack extends cdk.Stack { | |||
| memoryLimitMiB: 512, | |||
| cpu: 1, | |||
| environment: { name: 'TRIGGER', value: 'CloudWatch Events' }, | |||
| scheduleExpression: 'rate(1 minute)' | |||
| schedule: events.Schedule.fromRate(1, events.TimeUnit.Minute), | |||
There was a problem hiding this comment.
I don’t like the “from” prefix. It doesn’t read right. It’s not “schedule from rate”. I think just “Schedule.rate” feels better.
There was a problem hiding this comment.
Could we maybe use the Duration class here somehow? This is a length of time...
There was a problem hiding this comment.
It's not merged yet, is it?
| */ | ||
| readonly weekDay?: string; | ||
| } | ||
|
|
There was a problem hiding this comment.
Why do we need this subclass?
There was a problem hiding this comment.
So that it becomes obvious for future contributors where to add extensions.
eladb
approved these changes
Jun 18, 2019
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Dec 13, 2019
This was referenced Jan 20, 2020
This was referenced Sep 24, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Biggest change is modeling the schedule types.
BREAKING CHANGE:
EventPattern.detailis now a map.scheduleExpression: stringis nowschedule: Schedule.Pull Request Checklist
designfolderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.