-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(secretsmanager): hosted rotation with fromSecretNameV2() does not create correct iam policy #28379
Merged
mergify
merged 9 commits into
aws:main
from
go-to-k:fix/secret-hosted-schedule-from-method
Dec 20, 2023
Merged
fix(secretsmanager): hosted rotation with fromSecretNameV2() does not create correct iam policy #28379
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
85ba900
fix(secretsmanager): hosted rotation does not generate correct policy…
go-to-k c7c0b9c
Merge branch 'main' of https://github.com/go-to-k/aws-cdk into fix/se…
go-to-k f82667a
modify for fromArn methods
go-to-k 0f7b8da
wip
go-to-k 97586f8
snapshot
go-to-k e00eae0
Merge branch 'main' into fix/secret-hosted-schedule-from-method
go-to-k efd98b6
change test names
go-to-k e6911ab
change test names again
go-to-k f359c12
Merge branch 'main' into fix/secret-hosted-schedule-from-method
paulhcsun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (this.masterSecret?.secretFullArn)
this.masterSecret
in the stack, here is true.this.masterSecret
is generated fromfromSecretArn()
,fromSecretCompleteArn()
methods, etc. They also have a full ARN, so here is also true.if
statement will be true even if the arg (so it is the arn) for the methods is a token or not.else if (this.masterSecret)
ISecret
as an imported secret with partial ARN. It is generated fromfromSecretNameV2()
.secretArn
in this block will be a token. But processing this string is not a problem because the CloudFormation template can useFn::Join
to combine them properly. (see the unit tests.)