feat(codebuild): add functionality to allow using private registry an… #2796
Conversation
…d cross-account ECR repository as build image Fixes aws#2175
Kaixiang-AWS
requested review from
RomainMuller,
skinny85 and
a team
as code owners
| 'ecr:BatchCheckLayerAvailability' | ||
| ); | ||
| function isECRImage(imageUri: string) { | ||
| return /^(.+).dkr.ecr.(.+).amazonaws.com[.]{0,1}[a-z]{0,3}\/([^:]+):?.*$/.test(imageUri); |
There was a problem hiding this comment.
You should ensure imageUri can be parsed using Token.unresolved
| @@ -1023,7 +1060,7 @@ export interface IBuildImage { | |||
| * | |||
| * You can also specify a custom image using one of the static methods: | |||
| * | |||
| * - LinuxBuildImage.fromDockerHub(image) | |||
| * - LinuxBuildImage.fromDockerRegistry(image[, secretsManagerCredential]) | |||
There was a problem hiding this comment.
In that case, we'd probably need some generic modeling of Docker images, using @aws-cdk/docker or something.
There was a problem hiding this comment.
Discussed offline. We decided not create a general Docker image API. Given that, I believe this code is fine - what do you think @eladb ?
…d cross-account ECR repository as build image Fixes aws#2175
|
Hey @Kaixiang-AWS , apologies for not helping you with this PR sooner. I promise I'll improve from now on 🤞. I see there are some conflicts with master, and I believe some accidental changes in the Thanks, |
I'm working on the rebasing and will have a PR out soon |
|
can we close this PR, now that #3049 has been opened? |
|
tracking in #3049 |
…d cross-account ECR repository as build image
Fixes #2175
Pull Request Checklist
designfolderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.