v0.34.0 #2791
Merged
v0.34.0 #2791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rix0rrr
requested review from
RomainMuller,
skinny85,
SoManyHs and
a team
as code owners
RomainMuller
suggested changes
Jun 7, 2019
CHANGELOG.md
Outdated
| * **core:** Properties passed to `addPropertyOverride` should match in capitalization to the CloudFormation schema (normally pascal case). For example, `addPropertyOverride('accessControl', 'xxx')` should now be `addPropertyOverride('AccessControl', 'xxx')`. | ||
|
|
||
|
|
||
|
|
||
| # Change Log |
There was a problem hiding this comment.
Isn't this meant to be at the very top of the file?
eladb
approved these changes
Jun 7, 2019
CHANGELOG.md
Outdated
| * **route53:** `recordValue: string` prop in `route53.TxtRecord` changed to `values: string[]` | ||
| * `recordValue` prop in `route53.CnameRecord` renamed to `domainName` | ||
| * `route53.AliasRecord` has been removed, use `route53.ARecord` or `route53.AaaaRecord` with the `target` prop. | ||
| * **core:** |
CHANGELOG.md
Outdated
| * **kms:** The `EncryptionKeyAlias` class was renamed to `Alias`. | ||
| Associated types (such as `EncryptionKeyAliasProps`) were renamed in the | ||
| same way. | ||
| * **core:** * **cli:** This release requires CDK CLI >= 0.34.0 |
RomainMuller
approved these changes
Jun 7, 2019
|
Build is broken atm, need a patch on jsii before we can merge this release. |
jogold
reviewed
Jun 7, 2019
| * **tokens:** enable type coercion ([#2680](https://github.com/awslabs/aws-cdk/issues/2680)) ([0f54698](https://github.com/awslabs/aws-cdk/commit/0f54698)), closes [#2679](https://github.com/awslabs/aws-cdk/issues/2679) | ||
|
|
||
|
|
||
| ### BREAKING CHANGES |
There was a problem hiding this comment.
The following breaking changes from #2187 are missing (were not included in the final PR description):
rds.RotationSingleUserrenamed tords.SecretRotationrds.ClusterParameterGroupno longer hassetParameter()andremoveParameter()methods, use theparametersprop directly in the constructor instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See CHANGELOG
Pull Request Checklist
designfolderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.