chore: check region-info completeness #27771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the compatibility check, also check that no facts have disappeared from the `region-info` database.
aws-cdk-automation
added
the
pr/needs-maintainer-review
This reverts commit 174aa6b.
|
|
||
| const disappearedFacts = oldFacts.filter((oldFact) => !newFacts.some((newFact) => factEq(oldFact, newFact))); | ||
| if (disappearedFacts.length > 0) { | ||
| console.log('Facts have disappeared from region fact database (add to allowed-breaking-changes.txt to ignore):'); |
There was a problem hiding this comment.
Shouldn't we log this only if we are sure to exit with code 1?
otaviomacedo
approved these changes
Oct 31, 2023
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mrgrain
pushed a commit
that referenced
this pull request
Nov 1, 2023
During the compatibility check, also check that no facts have disappeared from the `region-info` database. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the compatibility check, also check that no facts have disappeared from the
region-infodatabase.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license