Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(opensearchservice): IM4GN instances don't support EBS #27765

Merged
merged 6 commits into from
Nov 2, 2023
Merged

fix(opensearchservice): IM4GN instances don't support EBS #27765

merged 6 commits into from
Nov 2, 2023

Conversation

msambol
Copy link
Contributor

@msambol msambol commented Oct 30, 2023 •
edited by scanlonp
Loading

Relevant docs https://aws.amazon.com/opensearch-service/pricing/

Closes #27757.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added admired-contributor [Pilot] contributed between 13-24 PRs to the CDK bug This issue is a bug. p2 labels Oct 30, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team October 30, 2023 21:34
msambol
msambol commented Oct 30, 2023
View reviewed changes
packages/aws-cdk-lib/aws-opensearchservice/lib/domain.ts Outdated
if (isSomeInstanceType('i3', 'r6gd') && ebsEnabled) {
throw new Error('I3 and R6GD instance types do not support EBS storage volumes.');
if (isSomeInstanceType('r3', 'i3', 'r6gd', 'im4gn') && ebsEnabled) {
throw new Error('R3, I3, R6GD and IM4GN instance types do not support EBS storage volumes.');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this if was missing r3

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs linked above say that r3 is incompatible with encryption at rest but is silent about EBS specifically. Are the service docs missing that fact, is there another source for that limitation? https://docs.aws.amazon.com/opensearch-service/latest/developerguide/supported-instance-types.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that doc is missing it? On the pricing page, it doesn't have EBS and is similar to i3, r6gd, and im4gn.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kylelaker Let me fix this. I tested in the Console and you are allowed to have EBS for R3.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kylelaker Thanks for catching this! I confirmed r3 supports both instance and EBS.

aws-cdk-automation
aws-cdk-automation previously requested changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@msambol
Copy link
Contributor Author

msambol commented Oct 30, 2023

Exemption Request: I don't think integration test changes are needed for these logic checks but happy to add them if needed.

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Oct 30, 2023
@msambol
Copy link
Contributor Author

msambol commented Oct 31, 2023

Exemption Request: I don't think integration test changes are needed for these logic checks but happy to add them if needed.

laurelmay
laurelmay approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@laurelmay laurelmay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into the R3 instances more! This looks good for adding the IM4GN support.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 1, 2023
@github-actions github-actions bot mentioned this pull request Nov 1, 2023
Closed
@github-actions github-actions bot added the effort/small Small work item – less than a day of effort label Nov 2, 2023
scanlonp
scanlonp approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition. Thanks!

I do not think we need the integ test in this case. I do not see instance type checks in any of our integ tests. The unit test should be sufficient.

@scanlonp scanlonp added pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Nov 2, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 2, 2023 02:29

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 2, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 2, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 2, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: dac5b12
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit af1f6bd into aws:main Nov 2, 2023
9 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 2, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurelmay laurelmay laurelmay approved these changes

@scanlonp scanlonp scanlonp approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
admired-contributor [Pilot] contributed between 13-24 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws-opensearchservice: No support for IM4GN instances
4 participants
@msambol @aws-cdk-automation @laurelmay @scanlonp