New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lambda): add function url metrics #27756

Closed

pedropedruzzi wants to merge 3 commits into aws:main from pedropedruzzi:patch-2

Contributor

pedropedruzzi commented Oct 30, 2023

Add Function URL metrics as described in https://docs.aws.amazon.com/lambda/latest/dg/urls-monitoring.html

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license


          lambda: Add Function URL metrics

5fed7ea

Add Function URL metrics as described in https://docs.aws.amazon.com/lambda/latest/dg/urls-monitoring.html

github-actions bot added the beginning-contributor label

aws-cdk-automation requested a review from a team

October 30, 2023 15:53

github-actions bot added the p2 label


          Formatting adjust (please stash)

aws-cdk-automation requested changes

View reviewed changes

Collaborator

aws-cdk-automation left a comment

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.


          Update AWS_Lambda_Function.json

cdbd07e

pedropedruzzi changed the title ~~lambda: Add Function URL metrics~~ feat(lambda): add function url metrics

Collaborator

aws-cdk-automation commented Oct 30, 2023

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: cdbd07e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

github-actions bot mentioned this pull request

Monthly PR metrics report - October 2023 #27786

Closed

Collaborator

aws-cdk-automation commented Nov 7, 2023

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

13 similar comments

Collaborator

aws-cdk-automation commented Nov 8, 2023

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

Collaborator

aws-cdk-automation commented Nov 9, 2023

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

Collaborator

aws-cdk-automation commented Nov 10, 2023

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

Collaborator

aws-cdk-automation commented Nov 11, 2023

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

Collaborator

aws-cdk-automation commented Nov 12, 2023

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

Collaborator

aws-cdk-automation commented Nov 13, 2023

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

Collaborator

aws-cdk-automation commented Nov 14, 2023

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

Collaborator

aws-cdk-automation commented Nov 15, 2023

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

Collaborator

aws-cdk-automation commented Nov 16, 2023

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

Collaborator

aws-cdk-automation commented Nov 17, 2023

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

Collaborator

aws-cdk-automation commented Nov 18, 2023

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

Collaborator

aws-cdk-automation commented Nov 19, 2023

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

Collaborator

aws-cdk-automation commented Nov 20, 2023

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

Collaborator

aws-cdk-automation commented Nov 21, 2023

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

Collaborator

aws-cdk-automation commented Nov 29, 2023

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

aws-cdk-automation added the closed-for-staleness label

aws-cdk-automation closed this

vinayak-kukreja reopened this

Collaborator

aws-cdk-automation commented Dec 6, 2023

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

aws-cdk-automation closed this

paulhcsun added pr-linter/do-not-close and removed closed-for-staleness labels

paulhcsun reopened this

Collaborator

aws-cdk-automation commented Dec 7, 2023

The pull request linter fails with the following errors:

❌ Features must contain a change to a README file.
❌ Features must contain a change to a test file.
❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

1 similar comment

Collaborator

aws-cdk-automation commented Dec 7, 2023

The pull request linter fails with the following errors:

❌ Features must contain a change to a README file.
❌ Features must contain a change to a test file.
❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

Contributor

kaizencc commented Dec 12, 2023

Not sure why we reopened this. Clearly this PR has been abandoned. @pedropedruzzi if you would like to continue your contribution, please open a new PR and make sure that at a minimum, the build succeeds and the automated review is passing.

kaizencc closed this

paulhcsun mentioned this pull request

chore: update workflow to not close unreviewed stale PRs rix0rrr/close-stale-prs#3

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beginning-contributor p2 pr-linter/do-not-close