feat(ec2): support for r7i instance type in aws-ec2 #27737
Conversation
github-actions
bot
added
beginning-contributor
|
Exemption Request This PR is similar to this PR, which didn't need changes to the README or tests. |
aws-cdk-automation
added
the
pr-linter/exemption-requested
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
added
the
pr/needs-community-review
scanlonp
added
pr-linter/exempt-readme
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
There was a problem hiding this comment.
The doc string for r7i is the same as r7iz. There is also no "word" representation of the instance. Can we add one?
I suspect that MEMORY7_INTEL should have corresponded to r7i, but it is coupled with r7iz. We cannot change that now, but maybe we can come up with a good name for r7i. (Also we can put a comment that this is a 1-time deviation from our pattern.)
| @@ -326,6 +326,11 @@ export enum InstanceClass { | |||
| */ | |||
| R7GD = 'r7gd', | |||
|
|
|||
| /** | |||
| * Memory optimized instances based on Intel Xeon Scalable (Sapphire Rapids) processors, 7th generation | |||
There was a problem hiding this comment.
Lets change this to not be the same as r7iz. Or if the better change would be to that doc string, do that.
There was a problem hiding this comment.
i agree, i had difficulty finding the nuanced difference between the r7i and r7iz, unfortunately you're correct, the MEMORY7_INTEL should have gone to the r7i instead of the r7iz, but I had thought the r7iz was the replacement for the r7i since it used the same processor generation as the c7i and m7i.
I'm totally open to suggestions, but happy to take a stab at it for community review.
There was a problem hiding this comment.
Yes, that mistake is on me. Do what you think looks good and we can go from there!
aws-cdk-automation
removed
the
pr/needs-community-review
mergify
bot
dismissed
scanlonp’s stale review
Pull request has been modified.
aws-cdk-automation
added
the
pr/needs-community-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Support of R7i EC2-Instance type in aws-ec2. The [R7i](https://aws.amazon.com/ec2/instance-types/r7i/) was recently introduced in October 2023. The R7i instance type has been confirmed to be supported in [AWS-Cloudformation](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-instance.html#cfn-ec2-instance-instancetype). ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Support of R7i EC2-Instance type in aws-ec2.
The R7i was recently introduced in October 2023.
The R7i instance type has been confirmed to be supported in AWS-Cloudformation.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license