Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove omitEmptyArray default in Ec2Service constructor #27688

Closed
wants to merge 9 commits into from
Closed

fix: remove omitEmptyArray default in Ec2Service constructor #27688

wants to merge 9 commits into from

Conversation

123MwanjeMike
Copy link

Removes omitEmptyArray default in Ec2Service constructor to fix #27555

Addresses reasons for closure of #27572

Closes #27555


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team October 26, 2023 09:45
@github-actions github-actions bot added bug This issue is a bug. p1 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Oct 26, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@123MwanjeMike
Copy link
Author

Clarification Request

@aws-cdk-automation aws-cdk-automation added the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Oct 26, 2023
@123MwanjeMike
Copy link
Author

123MwanjeMike commented Oct 26, 2023

Where and how do I add the integration test to fix the message below?

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

I can't seem to find the respective integration test file.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ab839e1
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@khushail
Copy link
Contributor

khushail commented Nov 2, 2023

Where and how do I add the integration test to fix the message below?

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

I can't seem to find the respective integration test file.

Here is the Intergation test guide and tests would reside here- "@aws-cdk-testing/framework-integ/test/MODULE_NAME/test".

@sumupitchayan
Copy link
Contributor

@123MwanjeMike Yes, please check out our integration test guide and update this PR with those changes, we will take a look once you've added them

@sumupitchayan sumupitchayan removed the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Nov 7, 2023
@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Nov 25, 2023
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_cdk.aws_ecs: empty placement constraints / placement strategies not allowed
4 participants