Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(spec2cdk): generate ICfnResource interface #27681

Merged
merged 11 commits into from
Nov 2, 2023

Conversation

kaizencc
Copy link
Contributor

Generates something that looks like this for all resources:

interface ICfnResource {
  readonly attrName: string;    // { Ref }, i.e. the primaryIdentifier
  readonly attrArn: string;     // { Fn::GetAtt }, if applicable
}

In a separate PR, we will update all CfnResources to extend ICfnResource, and then later on, update some Resources to extend ICfnResource as well.

This PR targets conroy/generate as a horribly named branch off of main which will house all pieces of this puzzle before unleashing onto main.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team October 25, 2023 18:39
@github-actions github-actions bot added the p2 label Oct 25, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 25, 2023
@kaizencc kaizencc marked this pull request as draft October 25, 2023 19:50
@kaizencc kaizencc marked this pull request as ready for review October 30, 2023 20:53
@mrgrain mrgrain merged commit b2da9db into conroy/generate Nov 2, 2023
7 checks passed
@mrgrain mrgrain deleted the conroy/generate-first branch November 2, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants