docs(secretsmanager): doc when automaticallyAfter for RotationSchedule is 0 is wrong #27570

go-to-k · 2023-10-17T06:48:58Z

We discussed that the doc when automaticallyAfter for RotationSchedule is Duration.days(0) is wrong. So I modified the doc.

See the issue (#27460) and another PR (#27497 (comment)).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…e is 0 is wrong

lpizzinidev

Thanks 👍
Since we are here, I think we should add validation to verify that automaticallyAfter is not greater than 1000 days.

go-to-k · 2023-10-17T15:50:34Z

@lpizzinidev

Thanks for your review. I added the validation!

lpizzinidev

Thanks 👍
Just an addition to the documentation.
Also, we may think about splitting this in two:

The initial docs task on this PR
The chore of adding validation on a new PR

lpizzinidev · 2023-10-18T07:39:03Z

packages/aws-cdk-lib/aws-secretsmanager/lib/rotation-schedule.ts

@@ -37,7 +37,7 @@ export interface RotationScheduleOptions {
   * Specifies the number of days after the previous rotation before
   * Secrets Manager triggers the next automatic rotation.
   *


Suggested change

*

*

* The maximum value is 1000 days.

*

Documentation about accepted values.

https://github.com/aws/aws-cdk/pull/27592/files

lpizzinidev · 2023-10-18T07:50:27Z

packages/aws-cdk-lib/aws-secretsmanager/lib/rotation-schedule.ts

+    if (props.automaticallyAfter && props.automaticallyAfter.toDays() > 1000) {
+      throw new Error(`automaticallyAfter must not be greater than 1000 days, got ${props.automaticallyAfter.toDays()} days`);
+    }
+    if (!props.automaticallyAfter || props.automaticallyAfter.toMilliseconds() !== 0) {


Suggested change

if (!props.automaticallyAfter || props.automaticallyAfter.toMilliseconds() !== 0) {

if (props.automaticallyAfter?.toMilliseconds() !== 0) {

Since they are equivalent I think it's better to keep the concise version (unless I'm missing something).

https://github.com/aws/aws-cdk/pull/27592/files

go-to-k · 2023-10-18T08:48:41Z

@lpizzinidev

Also, we may think about splitting this in two:

The initial docs task on this PR
The chore of adding validation on a new PR

OK! I will submit a new PR for the chore of adding validation. This issue here will be on just doc.

go-to-k · 2023-10-18T09:08:16Z

@lpizzinidev

I submitted a new PR for the validation of maximum value.

https://github.com/aws/aws-cdk/pull/27592/files

mergify · 2023-10-18T17:17:42Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2023-10-18T17:46:54Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: d28ac34
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2023-10-18T17:47:11Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

… RotationSchedule (#27592) I added a validation for whether `automaticallyAfter` in `RotationSchedule` is not greater than 1000 days. We discussed in the following threads. #27570 (review) #27570 (review) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---|---|---| | | | lockFileMaintenance | All locks refreshed | [![age](https://developer.mend.io/api/mc/badges/age///?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption///?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility////?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence////?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@aws-cdk/aws-apigatewayv2-alpha](https://togithub.com/aws/aws-cdk) | dependencies | minor | [`2.102.0-alpha.0` -> `2.103.1-alpha.0`](https://renovatebot.com/diffs/npm/@aws-cdk%2faws-apigatewayv2-alpha/2.102.0-alpha.0/2.103.1-alpha.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@aws-cdk%2faws-apigatewayv2-alpha/2.103.1-alpha.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@aws-cdk%2faws-apigatewayv2-alpha/2.103.1-alpha.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@aws-cdk%2faws-apigatewayv2-alpha/2.102.0-alpha.0/2.103.1-alpha.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@aws-cdk%2faws-apigatewayv2-alpha/2.102.0-alpha.0/2.103.1-alpha.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@aws-cdk/aws-apigatewayv2-authorizers-alpha](https://togithub.com/aws/aws-cdk) | dependencies | minor | [`2.102.0-alpha.0` -> `2.103.1-alpha.0`](https://renovatebot.com/diffs/npm/@aws-cdk%2faws-apigatewayv2-authorizers-alpha/2.102.0-alpha.0/2.103.1-alpha.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@aws-cdk%2faws-apigatewayv2-authorizers-alpha/2.103.1-alpha.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@aws-cdk%2faws-apigatewayv2-authorizers-alpha/2.103.1-alpha.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@aws-cdk%2faws-apigatewayv2-authorizers-alpha/2.102.0-alpha.0/2.103.1-alpha.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@aws-cdk%2faws-apigatewayv2-authorizers-alpha/2.102.0-alpha.0/2.103.1-alpha.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@aws-cdk/aws-apigatewayv2-integrations-alpha](https://togithub.com/aws/aws-cdk) | dependencies | minor | [`2.102.0-alpha.0` -> `2.103.1-alpha.0`](https://renovatebot.com/diffs/npm/@aws-cdk%2faws-apigatewayv2-integrations-alpha/2.102.0-alpha.0/2.103.1-alpha.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@aws-cdk%2faws-apigatewayv2-integrations-alpha/2.103.1-alpha.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@aws-cdk%2faws-apigatewayv2-integrations-alpha/2.103.1-alpha.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@aws-cdk%2faws-apigatewayv2-integrations-alpha/2.102.0-alpha.0/2.103.1-alpha.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@aws-cdk%2faws-apigatewayv2-integrations-alpha/2.102.0-alpha.0/2.103.1-alpha.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@aws-sdk/client-dynamodb](https://togithub.com/aws/aws-sdk-js-v3/tree/main/clients/client-dynamodb) ([source](https://togithub.com/aws/aws-sdk-js-v3)) | dependencies | minor | [`3.433.0` -> `3.438.0`](https://renovatebot.com/diffs/npm/@aws-sdk%2fclient-dynamodb/3.433.0/3.438.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@aws-sdk%2fclient-dynamodb/3.438.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@aws-sdk%2fclient-dynamodb/3.438.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@aws-sdk%2fclient-dynamodb/3.433.0/3.438.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@aws-sdk%2fclient-dynamodb/3.433.0/3.438.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@aws-sdk/client-s3](https://togithub.com/aws/aws-sdk-js-v3/tree/main/clients/client-s3) ([source](https://togithub.com/aws/aws-sdk-js-v3)) | dependencies | minor | [`3.433.0` -> `3.438.0`](https://renovatebot.com/diffs/npm/@aws-sdk%2fclient-s3/3.433.0/3.438.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@aws-sdk%2fclient-s3/3.438.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@aws-sdk%2fclient-s3/3.438.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@aws-sdk%2fclient-s3/3.433.0/3.438.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@aws-sdk%2fclient-s3/3.433.0/3.438.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@aws-sdk/client-sesv2](https://togithub.com/aws/aws-sdk-js-v3/tree/main/clients/client-sesv2) ([source](https://togithub.com/aws/aws-sdk-js-v3)) | dependencies | minor | [`3.433.0` -> `3.438.0`](https://renovatebot.com/diffs/npm/@aws-sdk%2fclient-sesv2/3.433.0/3.438.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@aws-sdk%2fclient-sesv2/3.438.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@aws-sdk%2fclient-sesv2/3.438.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@aws-sdk%2fclient-sesv2/3.433.0/3.438.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@aws-sdk%2fclient-sesv2/3.433.0/3.438.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@aws-sdk/client-sfn](https://togithub.com/aws/aws-sdk-js-v3/tree/main/clients/client-sfn) ([source](https://togithub.com/aws/aws-sdk-js-v3)) | dependencies | minor | [`3.433.0` -> `3.438.0`](https://renovatebot.com/diffs/npm/@aws-sdk%2fclient-sfn/3.433.0/3.438.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@aws-sdk%2fclient-sfn/3.438.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@aws-sdk%2fclient-sfn/3.438.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@aws-sdk%2fclient-sfn/3.433.0/3.438.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@aws-sdk%2fclient-sfn/3.433.0/3.438.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@aws-sdk/s3-request-presigner](https://togithub.com/aws/aws-sdk-js-v3/tree/main/packages/s3-request-presigner) ([source](https://togithub.com/aws/aws-sdk-js-v3)) | dependencies | minor | [`3.433.0` -> `3.438.0`](https://renovatebot.com/diffs/npm/@aws-sdk%2fs3-request-presigner/3.433.0/3.438.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@aws-sdk%2fs3-request-presigner/3.438.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@aws-sdk%2fs3-request-presigner/3.438.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@aws-sdk%2fs3-request-presigner/3.433.0/3.438.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@aws-sdk%2fs3-request-presigner/3.433.0/3.438.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@mui/icons-material](https://mui.com/material-ui/material-icons/) ([source](https://togithub.com/mui/material-ui)) | dependencies | patch | [`5.14.14` -> `5.14.15`](https://renovatebot.com/diffs/npm/@mui%2ficons-material/5.14.14/5.14.15) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@mui%2ficons-material/5.14.15?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@mui%2ficons-material/5.14.15?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@mui%2ficons-material/5.14.14/5.14.15?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@mui%2ficons-material/5.14.14/5.14.15?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@mui/material](https://mui.com/material-ui/) ([source](https://togithub.com/mui/material-ui)) | dependencies | patch | [`5.14.14` -> `5.14.15`](https://renovatebot.com/diffs/npm/@mui%2fmaterial/5.14.14/5.14.15) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@mui%2fmaterial/5.14.15?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@mui%2fmaterial/5.14.15?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@mui%2fmaterial/5.14.14/5.14.15?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@mui%2fmaterial/5.14.14/5.14.15?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@mui/x-date-pickers](https://mui.com/x/react-date-pickers/) ([source](https://togithub.com/mui/mui-x)) | dependencies | minor | [`6.16.3` -> `6.17.0`](https://renovatebot.com/diffs/npm/@mui%2fx-date-pickers/6.16.3/6.17.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@mui%2fx-date-pickers/6.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@mui%2fx-date-pickers/6.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@mui%2fx-date-pickers/6.16.3/6.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@mui%2fx-date-pickers/6.16.3/6.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped)) | devDependencies | patch | [`18.18.6` -> `18.18.7`](https://renovatebot.com/diffs/npm/@types%2fnode/18.18.6/18.18.7) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@types%2fnode/18.18.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@types%2fnode/18.18.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@types%2fnode/18.18.6/18.18.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@types%2fnode/18.18.6/18.18.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@types/react](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped)) | devDependencies | patch | [`18.2.31` -> `18.2.33`](https://renovatebot.com/diffs/npm/@types%2freact/18.2.31/18.2.33) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@types%2freact/18.2.33?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@types%2freact/18.2.33?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@types%2freact/18.2.31/18.2.33?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@types%2freact/18.2.31/18.2.33?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`6.8.0` -> `6.9.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/6.8.0/6.9.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@typescript-eslint%2feslint-plugin/6.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@typescript-eslint%2feslint-plugin/6.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@typescript-eslint%2feslint-plugin/6.8.0/6.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@typescript-eslint%2feslint-plugin/6.8.0/6.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@typescript-eslint/parser](https://togithub.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`6.8.0` -> `6.9.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/6.8.0/6.9.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@typescript-eslint%2fparser/6.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@typescript-eslint%2fparser/6.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@typescript-eslint%2fparser/6.8.0/6.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@typescript-eslint%2fparser/6.8.0/6.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [aws-cdk](https://togithub.com/aws/aws-cdk) | devDependencies | minor | [`2.102.0` -> `2.103.1`](https://renovatebot.com/diffs/npm/aws-cdk/2.102.0/2.103.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/aws-cdk/2.103.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/aws-cdk/2.103.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/aws-cdk/2.102.0/2.103.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/aws-cdk/2.102.0/2.103.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [aws-cdk-lib](https://togithub.com/aws/aws-cdk) | dependencies | minor | [`2.102.0` -> `2.103.1`](https://renovatebot.com/diffs/npm/aws-cdk-lib/2.102.0/2.103.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/aws-cdk-lib/2.103.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/aws-cdk-lib/2.103.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/aws-cdk-lib/2.102.0/2.103.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/aws-cdk-lib/2.102.0/2.103.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [aws-sdk](https://togithub.com/aws/aws-sdk-js) | dependencies | minor | [`2.1478.0` -> `2.1483.0`](https://renovatebot.com/diffs/npm/aws-sdk/2.1478.0/2.1483.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/aws-sdk/2.1483.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/aws-sdk/2.1483.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/aws-sdk/2.1478.0/2.1483.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/aws-sdk/2.1478.0/2.1483.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [axios](https://axios-http.com) ([source](https://togithub.com/axios/axios)) | dependencies | minor | [`1.5.1` -> `1.6.0`](https://renovatebot.com/diffs/npm/axios/1.5.1/1.6.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/axios/1.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/axios/1.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/axios/1.5.1/1.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/axios/1.5.1/1.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [eslint-plugin-import](https://togithub.com/import-js/eslint-plugin-import) | devDependencies | minor | [`2.28.1` -> `2.29.0`](https://renovatebot.com/diffs/npm/eslint-plugin-import/2.28.1/2.29.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/eslint-plugin-import/2.29.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/eslint-plugin-import/2.29.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/eslint-plugin-import/2.28.1/2.29.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/eslint-plugin-import/2.28.1/2.29.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [oidc-client-ts](https://togithub.com/authts/oidc-client-ts) | dependencies | minor | [`2.3.0` -> `2.4.0`](https://renovatebot.com/diffs/npm/oidc-client-ts/2.3.0/2.4.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/oidc-client-ts/2.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/oidc-client-ts/2.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/oidc-client-ts/2.3.0/2.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/oidc-client-ts/2.3.0/2.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [vite-plugin-svgr](https://togithub.com/pd4d10/vite-plugin-svgr) | devDependencies | minor | [`4.0.0` -> `4.1.0`](https://renovatebot.com/diffs/npm/vite-plugin-svgr/4.0.0/4.1.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/vite-plugin-svgr/4.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/vite-plugin-svgr/4.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/vite-plugin-svgr/4.0.0/4.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/vite-plugin-svgr/4.0.0/4.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | 🔧 This Pull Request updates lock files to use the latest dependency versions. --- ### Release Notes <details> <summary>aws/aws-sdk-js-v3 (@aws-sdk/client-dynamodb)</summary> ### [`v3.438.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/clients/client-dynamodb/CHANGELOG.md#34380-2023-10-27) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.437.0...v3.438.0) **Note:** Version bump only for package [@aws-sdk/client-dynamodb](https://togithub.com/aws-sdk/client-dynamodb) ### [`v3.437.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/clients/client-dynamodb/CHANGELOG.md#34370-2023-10-26) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.436.0...v3.437.0) **Note:** Version bump only for package [@aws-sdk/client-dynamodb](https://togithub.com/aws-sdk/client-dynamodb) ### [`v3.436.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/clients/client-dynamodb/CHANGELOG.md#34360-2023-10-25) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.435.0...v3.436.0) **Note:** Version bump only for package [@aws-sdk/client-dynamodb](https://togithub.com/aws-sdk/client-dynamodb) ### [`v3.435.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/clients/client-dynamodb/CHANGELOG.md#34350-2023-10-24) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.433.0...v3.435.0) **Note:** Version bump only for package [@aws-sdk/client-dynamodb](https://togithub.com/aws-sdk/client-dynamodb) </details> <details> <summary>aws/aws-sdk-js-v3 (@aws-sdk/client-s3)</summary> ### [`v3.438.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/clients/client-s3/CHANGELOG.md#34380-2023-10-27) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.437.0...v3.438.0) **Note:** Version bump only for package [@aws-sdk/client-s3](https://togithub.com/aws-sdk/client-s3) ### [`v3.437.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/clients/client-s3/CHANGELOG.md#34370-2023-10-26) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.436.0...v3.437.0) ##### Bug Fixes - **signature-v4-crt:** remove dynamic imports (!) ([#5225](https://togithub.com/aws/aws-sdk-js-v3/issues/5225)) ([89f97b5](https://togithub.com/aws/aws-sdk-js-v3/commit/89f97b5cea8052510471cdad69acced9f5be60d1)) ### [`v3.436.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/clients/client-s3/CHANGELOG.md#34360-2023-10-25) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.435.0...v3.436.0) **Note:** Version bump only for package [@aws-sdk/client-s3](https://togithub.com/aws-sdk/client-s3) ### [`v3.435.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/clients/client-s3/CHANGELOG.md#34350-2023-10-24) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.433.0...v3.435.0) **Note:** Version bump only for package [@aws-sdk/client-s3](https://togithub.com/aws-sdk/client-s3) </details> <details> <summary>aws/aws-sdk-js-v3 (@aws-sdk/client-sesv2)</summary> ### [`v3.438.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/clients/client-sesv2/CHANGELOG.md#34380-2023-10-27) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.437.0...v3.438.0) **Note:** Version bump only for package [@aws-sdk/client-sesv2](https://togithub.com/aws-sdk/client-sesv2) ### [`v3.437.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/clients/client-sesv2/CHANGELOG.md#34370-2023-10-26) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.436.0...v3.437.0) **Note:** Version bump only for package [@aws-sdk/client-sesv2](https://togithub.com/aws-sdk/client-sesv2) ### [`v3.436.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/clients/client-sesv2/CHANGELOG.md#34360-2023-10-25) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.435.0...v3.436.0) **Note:** Version bump only for package [@aws-sdk/client-sesv2](https://togithub.com/aws-sdk/client-sesv2) ### [`v3.435.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/clients/client-sesv2/CHANGELOG.md#34350-2023-10-24) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.433.0...v3.435.0) **Note:** Version bump only for package [@aws-sdk/client-sesv2](https://togithub.com/aws-sdk/client-sesv2) </details> <details> <summary>aws/aws-sdk-js-v3 (@aws-sdk/client-sfn)</summary> ### [`v3.438.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/clients/client-sfn/CHANGELOG.md#34380-2023-10-27) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.437.0...v3.438.0) **Note:** Version bump only for package [@aws-sdk/client-sfn](https://togithub.com/aws-sdk/client-sfn) ### [`v3.437.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/clients/client-sfn/CHANGELOG.md#34370-2023-10-26) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.436.0...v3.437.0) **Note:** Version bump only for package [@aws-sdk/client-sfn](https://togithub.com/aws-sdk/client-sfn) ### [`v3.436.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/clients/client-sfn/CHANGELOG.md#34360-2023-10-25) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.435.0...v3.436.0) **Note:** Version bump only for package [@aws-sdk/client-sfn](https://togithub.com/aws-sdk/client-sfn) ### [`v3.435.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/clients/client-sfn/CHANGELOG.md#34350-2023-10-24) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.433.0...v3.435.0) **Note:** Version bump only for package [@aws-sdk/client-sfn](https://togithub.com/aws-sdk/client-sfn) </details> <details> <summary>aws/aws-sdk-js-v3 (@aws-sdk/s3-request-presigner)</summary> ### [`v3.438.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/packages/s3-request-presigner/CHANGELOG.md#34380-2023-10-27) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.437.0...v3.438.0) **Note:** Version bump only for package [@aws-sdk/s3-request-presigner](https://togithub.com/aws-sdk/s3-request-presigner) ### [`v3.437.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/packages/s3-request-presigner/CHANGELOG.md#34370-2023-10-26) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.436.0...v3.437.0) **Note:** Version bump only for package [@aws-sdk/s3-request-presigner](https://togithub.com/aws-sdk/s3-request-presigner) ### [`v3.436.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/packages/s3-request-presigner/CHANGELOG.md#34360-2023-10-25) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.435.0...v3.436.0) **Note:** Version bump only for package [@aws-sdk/s3-request-presigner](https://togithub.com/aws-sdk/s3-request-presigner) ### [`v3.435.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/packages/s3-request-presigner/CHANGELOG.md#34350-2023-10-24) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.433.0...v3.435.0) **Note:** Version bump only for package [@aws-sdk/s3-request-presigner](https://togithub.com/aws-sdk/s3-request-presigner) </details> <details> <summary>mui/material-ui (@mui/icons-material)</summary> ### [`v5.14.15`](https://togithub.com/mui/material-ui/blob/HEAD/CHANGELOG.md#51415) [Compare Source](https://togithub.com/mui/material-ui/compare/v5.14.14...v5.14.15) *Oct 24, 2023* A big thanks to the 17 contributors who made this release possible. ##### `@mui/material@5.14.15` - \[Checkbox]\[Radio] Fix theme style overrides not working for different sizes ([#39377](https://togithub.com/mui/material-ui/issues/39377)) [@gitstart](https://togithub.com/gitstart) - \[InputLabel] InputLabel supports ownerState.focused for styleOverrides ([#39470](https://togithub.com/mui/material-ui/issues/39470)) [@mj12albert](https://togithub.com/mj12albert) - \[ToggleButton] Add `fullWidth` to `toggleButtonClasses` and `toggleButtonGroupClasses` ([#39536](https://togithub.com/mui/material-ui/issues/39536)) [@Semigradsky](https://togithub.com/Semigradsky) ##### `@mui/base@5.0.0-beta.21` - \[useAutocomplete] Correct keyboard navigation with multiple disabled options ([#38788](https://togithub.com/mui/material-ui/issues/38788)) [@VadimZvf](https://togithub.com/VadimZvf) - \[Select] Standardize box shadow on demos ([#39509](https://togithub.com/mui/material-ui/issues/39509)) [@zanivan](https://togithub.com/zanivan) - \[Slider] Refine demos ([#39526](https://togithub.com/mui/material-ui/issues/39526)) [@zanivan](https://togithub.com/zanivan) - \[Input] Update and port additional tests from material-ui ([#39584](https://togithub.com/mui/material-ui/issues/39584)) [@mj12albert](https://togithub.com/mj12albert) ##### `@mui/material-next@6.0.0-alpha.107` - \[FilledInput] Add FilledInput component ([#39307](https://togithub.com/mui/material-ui/issues/39307)) [@mj12albert](https://togithub.com/mj12albert) - \[InputAdornment] Fix unstable_capitalize import ([#39510](https://togithub.com/mui/material-ui/issues/39510)) [@DiegoAndai](https://togithub.com/DiegoAndai) - \[Snackbar] copy files to mui-material-next ([#39232](https://togithub.com/mui/material-ui/issues/39232)) [@Best-Sardar](https://togithub.com/Best-Sardar) - \[Menu] Use useMenu hook ([#38934](https://togithub.com/mui/material-ui/issues/38934)) [@mnajdova](https://togithub.com/mnajdova) ##### `@mui/joy@5.0.0-beta.12` - \[Button] Fix button size being a decorator ([#39529](https://togithub.com/mui/material-ui/issues/39529)) [@siriwatknp](https://togithub.com/siriwatknp) - \[CardOverflow] Remove conditional CSS to support Next.js App dir ([#39101](https://togithub.com/mui/material-ui/issues/39101)) [@siriwatknp](https://togithub.com/siriwatknp) - \[Link] Apply `userSelect: none` only when it's a button ([#39486](https://togithub.com/mui/material-ui/issues/39486)) [@mwskwong](https://togithub.com/mwskwong) ##### `@mui/lab@5.0.0-alpha.150` - Update peer dep of [@mui/material](https://togithub.com/mui/material) ([#39398](https://togithub.com/mui/material-ui/issues/39398)) [@brijeshb42](https://togithub.com/brijeshb42) ##### `@mui/zero-runtime@0.0.1-alpha.0` - Implement typings for public runtime API ([#39215](https://togithub.com/mui/material-ui/issues/39215)) [@brijeshb42](https://togithub.com/brijeshb42) ##### `@mui/zero-vite-plugin@0.0.1-alpha.0` - Modify plugin to transform node_modules ([#39517](https://togithub.com/mui/material-ui/issues/39517)) [@brijeshb42](https://togithub.com/brijeshb42) ##### Docs - \[base-ui] Standardize grey palette across demos ([#39504](https://togithub.com/mui/material-ui/issues/39504)) [@zanivan](https://togithub.com/zanivan) - \[base-ui] Overall demos design review ([#38820](https://togithub.com/mui/material-ui/issues/38820)) [@zanivan](https://togithub.com/zanivan) - \[joy-ui] Adjust the responsiveness of the template card ([#39534](https://togithub.com/mui/material-ui/issues/39534)) [@danilo-leal](https://togithub.com/danilo-leal) - \[material-ui] Typo fixes in overview page ([#39540](https://togithub.com/mui/material-ui/issues/39540)) [@Evan151](https://togithub.com/Evan151) - \[material-ui] Add stray design tweaks to the templates collection ([#39583](https://togithub.com/mui/material-ui/issues/39583)) [@danilo-leal](https://togithub.com/danilo-leal) - \[system] Revise the Box page ([#39159](https://togithub.com/mui/material-ui/issues/39159)) [@danilo-leal](https://togithub.com/danilo-leal) - Fix git diff format [@oliviertassinari](https://togithub.com/oliviertassinari) - \[I10n] Add Norwegian (nynorsk) (nn-NO) locale ([#39481](https://togithub.com/mui/material-ui/issues/39481)) [@hjalti-lifekeys](https://togithub.com/hjalti-lifekeys) - \[l10n] Fix double space typo in ar-EG [@oliviertassinari](https://togithub.com/oliviertassinari) - \[I10n] Additions to Icelandic (is-IS) locale ([#39480](https://togithub.com/mui/material-ui/issues/39480)) [@hjalti-lifekeys](https://togithub.com/hjalti-lifekeys) ##### Core - \[core] Replace a `useCallback` by `useRef` in useEventCallback ([#39078](https://togithub.com/mui/material-ui/issues/39078)) [@romgrk](https://togithub.com/romgrk) - \[docs-infra] Prevent docs crash ([#39214](https://togithub.com/mui/material-ui/issues/39214)) [@alexfauquette](https://togithub.com/alexfauquette) - \[docs-infra] Fix no-op autoprefixer warning ([#39385](https://togithub.com/mui/material-ui/issues/39385)) [@oliviertassinari](https://togithub.com/oliviertassinari) - \[docs-infra] Refine the API page design ([#39520](https://togithub.com/mui/material-ui/issues/39520)) [@alexfauquette](https://togithub.com/alexfauquette) - \[docs-infra] Fix cut-off sponsors ([#39572](https://togithub.com/mui/material-ui/issues/39572)) [@oliviertassinari](https://togithub.com/oliviertassinari) - \[website] Add missing h1 on page [@oliviertassinari](https://togithub.com/oliviertassinari) - \[website] Fix unrecognized prop warning [@oliviertassinari](https://togithub.com/oliviertassinari) - \[website] Store Engineer role filled [@oliviertassinari](https://togithub.com/oliviertassinari) - \[website] Add stray design adjustments ([#39496](https://togithub.com/mui/material-ui/issues/39496)) [@danilo-leal](https://togithub.com/danilo-leal) All contributors of this release in alphabetical order: [@alexfauquette](https://togithub.com/alexfauquette), [@Best-Sardar](https://togithub.com/Best-Sardar), [@brijeshb42](https://togithub.com/brijeshb42), [@danilo-leal](https://togithub.com/danilo-leal), [@DiegoAndai](https://togithub.com/DiegoAndai), [@Evan151](https://togithub.com/Evan151), [@gitstart](https://togithub.com/gitstart), [@hjalti-lifekeys](https://togithub.com/hjalti-lifekeys), [@mj12albert](https://togithub.com/mj12albert), [@mnajdova](https://togithub.com/mnajdova), [@mwskwong](https://togithub.com/mwskwong), [@oliviertassinari](https://togithub.com/oliviertassinari), [@romgrk](https://togithub.com/romgrk), [@Semigradsky](https://togithub.com/Semigradsky), [@siriwatknp](https://togithub.com/siriwatknp), [@VadimZvf](https://togithub.com/VadimZvf), [@zanivan](https://togithub.com/zanivan) </details> <details> <summary>mui/mui-x (@mui/x-date-pickers)</summary> ### [`v6.17.0`](https://togithub.com/mui/mui-x/blob/HEAD/CHANGELOG.md#6170) [Compare Source](https://togithub.com/mui/mui-x/compare/v6.16.3...v6.17.0) *Oct 27, 2023* We'd like to offer a big thanks to the 9 contributors who made this release possible. Here are some highlights ✨: - 🎁 The Tree View package is now officially stable! ![tree-view-example](https://togithub.com/mui/mui-x/assets/550141/77d1fe66-d912-49ba-b38f-b853fb90446a) - ✨ Improve the handling of non-numeric values by Data Grid aggregation - 🚀 Support lines with different domains on the line charts - 🐞 Bugfixes - 📚 Documentation improvements ##### Data Grid ##### `@mui/x-data-grid@6.17.0` - \[DataGrid] Allow custom debounce time for row positions calculation ([#10708](https://togithub.com/mui/mui-x/issues/10708)) [@cherniavskii](https://togithub.com/cherniavskii) - \[DataGrid] Persist stable row index for focused row ([#10674](https://togithub.com/mui/mui-x/issues/10674)) [@cherniavskii](https://togithub.com/cherniavskii) ##### `@mui/x-data-grid-pro@6.17.0` [![pro](https://mui.com/r/x-pro-svg)](https://mui.com/r/x-pro-svg-link "Pro plan") Same changes as in `@mui/x-data-grid@6.17.0`, plus: - \[DataGridPro] Fix `undefined` values passed to `valueFormatter` for tree leaf nodes ([#10748](https://togithub.com/mui/mui-x/issues/10748)) [@cherniavskii](https://togithub.com/cherniavskii) ##### `@mui/x-data-grid-premium@6.17.0` [![premium](https://mui.com/r/x-premium-svg)](https://mui.com/r/x-premium-svg-link "Premium plan") Same changes as in `@mui/x-data-grid-pro@6.17.0`, plus: - \[DataGridPremium] Fix `avg` aggregation to ignore non-numeric values ([#10787](https://togithub.com/mui/mui-x/issues/10787)) [@cherniavskii](https://togithub.com/cherniavskii) - \[DataGridPremium] Fix `size` aggregation to ignore `undefined` values ([#10745](https://togithub.com/mui/mui-x/issues/10745)) [@cherniavskii](https://togithub.com/cherniavskii) - \[DataGridPremium] Fix `sum` aggregation to ignore non-numeric values ([#10730](https://togithub.com/mui/mui-x/issues/10730)) [@cherniavskii](https://togithub.com/cherniavskii) - \[DataGridPremium] Fix cell selection throwing index error on second page and beyond ([#10784](https://togithub.com/mui/mui-x/issues/10784)) [@MBilalShafi](https://togithub.com/MBilalShafi) ##### Date Pickers ##### `@mui/x-date-pickers@6.17.0` - \[fields] POC: Use `contentEditable` on `FakeTextField` ([#10779](https://togithub.com/mui/mui-x/issues/10779)) [@flaviendelangle](https://togithub.com/flaviendelangle) - \[pickers] Fix weekday label localization ([#10809](https://togithub.com/mui/mui-x/issues/10809)) [@LukasTy](https://togithub.com/LukasTy) ##### `@mui/x-date-pickers-pro@6.17.0` [![pro](https://mui.com/r/x-pro-svg)](https://mui.com/r/x-pro-svg-link "Pro plan") Same changes as in `@mui/x-date-pickers@6.17.0`. ##### Charts / `@mui/x-charts@6.0.0-alpha.17` - \[charts] Fix text position in Safari ([#10815](https://togithub.com/mui/mui-x/issues/10815)) [@lhilgert9](https://togithub.com/lhilgert9) - \[charts] Support lines with different domains ([#10801](https://togithub.com/mui/mui-x/issues/10801)) [@alexfauquette](https://togithub.com/alexfauquette) ##### Tree View / `@mui/x-tree-view@6.17.0` No change ##### Docs - \[docs] Correct editing related props' description ([#10798](https://togithub.com/mui/mui-x/issues/10798)) [@MBilalShafi](https://togithub.com/MBilalShafi) - \[docs] Fix RTL data grid demo ([#10728](https://togithub.com/mui/mui-x/issues/10728)) [@oliviertassinari](https://togithub.com/oliviertassinari) - \[docs] Fix unclosed warning ([#10796](https://togithub.com/mui/mui-x/issues/10796)) [@flaviendelangle](https://togithub.com/flaviendelangle) - \[docs] Improve performance of `Save and restore the state from external storage` recipe ([#10811](https://togithub.com/mui/mui-x/issues/10811)) [@michelengelen](https://togithub.com/michelengelen) - \[test] Add missing type on `cleanText` utility function ([#10780](https://togithub.com/mui/mui-x/issues/10780)) [@flaviendelangle](https://togithub.com/flaviendelangle) </details> <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/eslint-plugin)</summary> ### [`v6.9.0`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#690-2023-10-23) [Compare Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v6.8.0...v6.9.0) ##### Bug Fixes - **eslint-plugin:** \[no-confusing-void-expression] handle unfixable cases ([#7674](https://togithub.com/typescript-eslint/typescript-eslint/issues/7674)) ([7e52f27](https://togithub.com/typescript-eslint/typescript-eslint/commit/7e52f276ed5b8b2c0b76be02cb2e8a77892c10f2)) - **eslint-plugin:** \[no-unsafe-return] allow returning anything if explicitly returning any ([#7708](https://togithub.com/typescript-eslint/typescript-eslint/issues/7708)) ([c6124b2](https://togithub.com/typescript-eslint/typescript-eslint/commit/c6124b2c93a53f11471cce8054388dec7a58f90b)) ##### Features - **eslint-plugin:** \[max-params] don't count `this: void` parameter ([#7696](https://togithub.com/typescript-eslint/typescript-eslint/issues/7696)) ([6398d3f](https://togithub.com/typescript-eslint/typescript-eslint/commit/6398d3fd0a576d8cdc957ec1b57929acacc60ba0)), closes [#7538](https://togithub.com/typescript-eslint/typescript-eslint/issues/7538) - **eslint-plugin:** \[naming-convention] add support for default and namespace imports ([#7269](https://togithub.com/typescript-eslint/typescript-eslint/issues/7269)) ([bb15aae](https://togithub.com/typescript-eslint/typescript-eslint/commit/bb15aae877ae260f59aa5e6cfc338b1eefc6d85c)) - **eslint-plugin:** \[no-restricted-imports] support import = require ([#7709](https://togithub.com/typescript-eslint/typescript-eslint/issues/7709)) ([4c8edcf](https://togithub.com/typescript-eslint/typescript-eslint/commit/4c8edcfb7d3cc02d07d2329c87da4377c1cbf969)) - **eslint-plugin:** \[no-unsafe-enum-comparison] add switch suggestion ([#7691](https://togithub.com/typescript-eslint/typescript-eslint/issues/7691)) ([53d5263](https://togithub.com/typescript-eslint/typescript-eslint/commit/53d5263cee8e0b5ddc5de3321d27559c196e5b58)), closes [#7643](https://togithub.com/typescript-eslint/typescript-eslint/issues/7643) - **eslint-plugin:** \[prefer-readonly] private fields support ([#7686](https://togithub.com/typescript-eslint/typescript-eslint/issues/7686)) ([0e875bf](https://togithub.com/typescript-eslint/typescript-eslint/commit/0e875bf77a9d94dc74924245fabc36c0ae780977)) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/parser)</summary> ### [`v6.9.0`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#690-2023-10-23) [Compare Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v6.8.0...v6.9.0) **Note:** Version bump only for package [@typescript-eslint/parser](https://togithub.com/typescript-eslint/parser) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>aws/aws-cdk (aws-cdk)</summary> ### [`v2.103.1`](https://togithub.com/aws/aws-cdk/releases/tag/v2.103.1) [Compare Source](https://togithub.com/aws/aws-cdk/compare/v2.103.0...v2.103.1) ##### Reverts - "fix(pipelines): using the same source (s3, connection, or codecommit) in a pipeline causes duplicate id error" ([#27700](https://togithub.com/aws/aws-cdk/issues/27700)) ([47db081](https://togithub.com/aws/aws-cdk/commit/47db081f610707d570dfafb1a7962c227c14426c)), closes [aws/aws-cdk#27602](https://togithub.com/aws/aws-cdk/issues/27602) *** ##### Alpha modules (2.103.1-alpha.0) ### [`v2.103.0`](https://togithub.com/aws/aws-cdk/releases/tag/v2.103.0) [Compare Source](https://togithub.com/aws/aws-cdk/compare/v2.102.1...v2.103.0) ##### Features - update AWS Service Spec ([#27650](https://togithub.com/aws/aws-cdk/issues/27650)) ([d1c36c6](https://togithub.com/aws/aws-cdk/commit/d1c36c6433aadc7394aa00847c1b8131b6a74346)) - **cli:** support `Fn::ImportValue` intrinsic function for hotswap deployments ([#27292](https://togithub.com/aws/aws-cdk/issues/27292)) ([a54ea0f](https://togithub.com/aws/aws-cdk/commit/a54ea0f2dd4c6525ac3fd264b6d0f085414d3a37)) - **ec2:** support for c7i and r7iz instance types in aws-ec2 ([#27611](https://togithub.com/aws/aws-cdk/issues/27611)) ([382a0ed](https://togithub.com/aws/aws-cdk/commit/382a0edadfdb4f1e505f920cad05e3321bd5c017)), closes [/docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-instance.html#cfn-ec2](https://togithub.com/aws//docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-instance.html/issues/cfn-ec2) - **ec2:** support for i4g instance types in aws-ec2 ([#27639](https://togithub.com/aws/aws-cdk/issues/27639)) ([039071d](https://togithub.com/aws/aws-cdk/commit/039071dde0fe3bc40978e6f967a58ac63cbdda8f)), closes [/docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ec2-instance.html#cfn-ec2](https://togithub.com/aws//docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ec2-instance.html/issues/cfn-ec2) [#27631](https://togithub.com/aws/aws-cdk/issues/27631) - **lambda:** add grantInvokeCompositePrincipal method ([#27529](https://togithub.com/aws/aws-cdk/issues/27529)) ([447b63c](https://togithub.com/aws/aws-cdk/commit/447b63ce636884c9c86e36e783aee73a3b489d90)), closes [#27503](https://togithub.com/aws/aws-cdk/issues/27503) - **opensearch:** OpenSearch 2.9 engine version ([#27612](https://togithub.com/aws/aws-cdk/issues/27612)) ([1f7075f](https://togithub.com/aws/aws-cdk/commit/1f7075f8bd6bd3c1d760cb9e899a7cba52e2993a)), closes [#27574](https://togithub.com/aws/aws-cdk/issues/27574) - **secretsmanager:** validate maximum value of automaticallyAfter in RotationSchedule ([#27592](https://togithub.com/aws/aws-cdk/issues/27592)) ([99740b3](https://togithub.com/aws/aws-cdk/commit/99740b3211d09e573e7b30e0e0baa7e3e5669447)), closes [/github.com/aws/aws-cdk/pull/27570#pullrequestreview-1682163803](https://togithub.com/aws//github.com/aws/aws-cdk/pull/27570/issues/pullrequestreview-1682163803) [/github.com/aws/aws-cdk/pull/27570#pullrequestreview-1684311044](https://togithub.com/aws//github.com/aws/aws-cdk/pull/27570/issues/pullrequestreview-1684311044) - **synthetics:** syn-python-selenium-2.0 runtime ([#27565](https://togithub.com/aws/aws-cdk/issues/27565)) ([1a89ef9](https://togithub.com/aws/aws-cdk/commit/1a89ef9632d89094486fab26b7cc930c0c83aab0)), closes [#27566](https://togithub.com/aws/aws-cdk/issues/27566) ##### Bug Fixes - **cdk:** Add AppSync:Api_Key as hot swappable and fix a bug with AppSync.function ([#27559](https://togithub.com/aws/aws-cdk/issues/27559)) ([12ff023](https://togithub.com/aws/aws-cdk/commit/12ff0235e5b6909691f656da1707c039f7000dbe)) - **ec2:** naming collisions when using `ec2.InitFile.fromAsset()` on multiple instances in the same stack ([#27468](https://togithub.com/aws/aws-cdk/issues/27468)) ([fc3be31](https://togithub.com/aws/aws-cdk/commit/fc3be313daf40bbf12b55f0b3ed3027505ca3a87)), closes [#16891](https://togithub.com/aws/aws-cdk/issues/16891) [/github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-ec2/lib/cfn-init-elements.ts#L427](https://togithub.com/aws//github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-ec2/lib/cfn-init-elements.ts/issues/L427) - **pipelines:** using the same source (s3, connection, or codecommit) in a pipeline causes duplicate id error ([#27602](https://togithub.com/aws/aws-cdk/issues/27602)) ([70acc84](https://togithub.com/aws/aws-cdk/commit/70acc844e2a652aea4f1328e4e758c3c5030d501)), closes [#23916](https://togithub.com/aws/aws-cdk/issues/23916) [#19875](https://togithub.com/aws/aws-cdk/issues/19875) - **region-info:** facts only returned from constant region list ([#27506](https://togithub.com/aws/aws-cdk/issues/27506)) ([7121c7e](https://togithub.com/aws/aws-cdk/commit/7121c7ee9eed595acfed1fb09f55b8bd966c01e3)), closes [#27260](https://togithub.com/aws/aws-cdk/issues/27260) - **stepfunctions-tasks:** cloudwatchlogs service generates wrong action in role policy ([#27623](https://togithub.com/aws/aws-cdk/issues/27623)) ([de7fb04](https://togithub.com/aws/aws-cdk/commit/de7fb043c37569d39776623fe137860e279b9fbf)), closes [#27573](https://togithub.com/aws/aws-cdk/issues/27573) *** #### Alpha modules (2.103.0-alpha.0) ##### Features - **schedule-alpha:** support customer managed KMS keys ([#27609](https://togithub.com/aws/aws-cdk/issues/27609)) ([df24d22](https://togithub.com/aws/aws-cdk/commit/df24d22a2afae63a6fc7683ddbe2659cc269230d)), closes [#27543](https://togithub.com/aws/aws-cdk/issues/27543) ### [`v2.102.1`](https://togithub.com/aws/aws-cdk/releases/tag/v2.102.1) [Compare Source](https://togithub.com/aws/aws-cdk/compare/v2.102.0...v2.102.1) ##### Bug Fixes - **region-info:** adding missing regions for kinesisfirehose ([#27672](https://togithub.com/aws/aws-cdk/pull/27672)) ([46372e0](https://togithub.com/aws/aws-cdk/commit/46372e040cbb713174c3a92ae627eb1fd2d4e836)), closes [#27656](https://togithub.com/aws/aws-cdk/issues/27656) *** #### Alpha modules (2.102.1-alpha.0) </details> <details> <summary>aws/aws-sdk-js (aws-sdk)</summary> ### [`v2.1483.0`](https://togithub.com/aws/aws-sdk-js/blob/HEAD/CHANGELOG.md#214830) [Compare Source](https://togithub.com/aws/aws-sdk-js/compare/v2.1482.0...v2.1483.0) - feature: EMR: Updated CreateCluster API request and DescribeCluster API responses to include EbsRootVolumeIops, and EbsRootVolumeThroughput attributes that specify the user configured root volume IOPS and throughput for Amazon EBS root device volume. This feature will be available from Amazon EMR releases 6.15.0 - feature: Neptune: Update TdeCredentialPassword type to SensitiveString - feature: Redshift: added support to create a dual stack cluster ### [`v2.1482.0`](https://togithub.com/aws/aws-sdk-js/blob/HEAD/CHANGELOG.md#214820) [Compare Source](https://togithub.com/aws/aws-sdk-js/compare/v2.1481.0...v2.1482.0) - feature: AppStream: This release introduces multi-session fleets, allowing customers to provision more than one user session on a single fleet instance. - feature: EC2: Launching GetSecurityGroupsForVpc API. This API gets security groups that can be associated by the AWS account making the request with network interfaces in the specified VPC. - feature: NetworkFirewall: Network Firewall now supports inspection of outbound SSL/TLS traffic. - feature: OpenSearch: You can specify ipv4 or dualstack IPAddressType for cluster endpoints. If you specify IPAddressType as dualstack, the new endpoint will be visible under the 'EndpointV2' parameter and will support IPv4 and IPv6 requests. Whereas, the 'Endpoint' will continue to serve IPv4 requests. - feature: Redshift: Add Redshift APIs GetResourcePolicy, DeleteResourcePolicy, PutResourcePolicy and DescribeInboundIntegrations for the new Amazon Redshift Zero-ETL integration feature, which can be used to control data ingress into Redshift namespace, and view inbound integrations. - feature: SNS: Message Archiving and Replay is now supported in Amazon SNS for FIFO topics. - feature: SageMaker: Amazon Sagemaker Autopilot now supports Text Generation jobs. - feature: SsmSap: AWS Systems Manager for SAP added support for registration and discovery of SAP ABAP applications - feature: Transfer: No API changes from previous release. This release migrated the model to Smithy keeping all features unchanged. ### [`v2.1481.0`](https://togithub.com/aws/aws-sdk-js/blob/HEAD/CHANGELOG.md#214810) [Compare Source](https://togithub.com/aws/aws-sdk-js/compare/v2.1480.0...v2.1481.0) - feature: ConnectCases: Increase maximum length of CommentBody to 3000, and increase maximum length of StringValue to 1500 - feature: GroundStation: This release will allow KMS alias names to be used when creating Mission Profiles - feature: IAM: Updates to GetAccessKeyLastUsed action to replace NoSuchEntity error with AccessDeniedException error. ### [`v2.1480.0`](https://togithub.com/aws/aws-sdk-js/blob/HEAD/CHANGELOG.md#214800) [Compare Source](https://togithub.com/aws/aws-sdk-js/compare/v2.1479.0...v2.1480.0) - feature: CodePipeline: Add ability to trigger pipelines from git tags, define variables at pipeline level and new pipeline type V2. - feature: EC2: This release updates the documentation for InstanceInterruptionBehavior and HibernationOptionsRequest to more accurately describe the behavior of these two parameters when using Spot hibernation. - feature: EKS: Added support for Cluster Subnet and Security Group mutability. - feature: IAM: Add the partitional endpoint for IAM in iso-f. - feature: MigrationHubConfig: This release introduces DeleteHomeRegionControl API that customers can use to delete the Migration Hub Home Region configuration - feature: MigrationHubStrategy: This release introduces multi-data-source feature in Migration Hub Strategy Recommendations. This feature now supports vCenter as a data source to fetch inventory in addition to ADS and Import from file workflow that is currently supported with MHSR collector. - feature: OpenSearchServerless: This release includes the following new APIs: CreateLifecyclePolicy, UpdateLifecyclePolicy, BatchGetLifecyclePolicy, DeleteLifecyclePolicy, ListLifecyclePolicies and BatchGetEffectiveLifecyclePolicy to support the data lifecycle management feature. ### [`v2.1479.0`](https://togithub.com/aws/aws-sdk-js/blob/HEAD/CHANGELOG.md#214790) [Compare Source](https://togithub.com/aws/aws-sdk-js/compare/v2.1478.0...v2.1479.0) - feature: MarketplaceCommerceAnalytics: The StartSupportDataExport operation has been deprecated as part of the Product Support Connection deprecation. As of December 2022, Product Support Connection is no longer supported. - feature: NetworkManager: This release adds API support for Tunnel-less Connect (NoEncap Protocol) for AWS Cloud WAN - feature: RedshiftServerless: This release adds support for customers to see the patch version and workgroup version in Amazon Redshift Serverless. - feature: Rekognition: Amazon Rekognition introduces StartMediaAnalysisJob, GetMediaAnalysisJob, and ListMediaAnalysisJobs operations to run a bulk analysis of images with a Detect Moderation model. </details> <details> <summary>axios/axios (axios)</summary> ### [`v1.6.0`](https://togithub.com/axios/axios/blob/HEAD/CHANGELOG.md#160-2023-10-26) [Compare Source](https://togithub.com/axios/axios/compare/v1.5.1...v1.6.0) ##### Bug Fixes - **CSRF:** fixed CSRF vulnerability CVE-2023-45857 ([#6028](https://togithub.com/axios/axios/issues/6028)) ([96ee232](https://togithub.com/axios/axios/commit/96ee232bd3ee4de2e657333d4d2191cd389e14d0)) - **dns:** fixed lookup function decorator to work properly in node v20; ([#6011](https://togithub.com/axios/axios/issues/6011)) ([5aaff53](https://togithub.com/axios/axios/commit/5aaff532a6b820bb9ab6a8cd0f77131b47e2adb8)) - **types:** fix AxiosHeaders types; ([#5931](https://togithub.com/axios/axios/issues/5931)) ([a1c8ad0](https://togithub.com/axios/axios/commit/a1c8ad008b3c13d53e135bbd0862587fb9d3fc09)) ##### PRs - CVE 2023 45857 ( [#6028](https://api.github.com/repos/axios/axios/pulls/6028) ) ``` ⚠️ Critical vulnerability fix. See https://security.snyk.io/vuln/SNYK-JS-AXIOS-6032459 ``` ##### Contributors to this release - <img src="https://avatars.githubusercontent.com/u/12586868?v=4&s=18" alt="avatar" width="18"/> [Dmitriy Mozgovoy](https://togithub.com/DigitalBrainJS "+449/-114 (#6032 #6021 #6011 #5932 #5931 )") - <img src="https://avatars.githubusercontent.com/u/63700910?v=4&s=18" alt="avatar" width="18"/> [Valentin Panov](https://togithub.com/valentin-panov "+4/-4 (#6028 )") - <img src="https://avatars.githubusercontent.com/u/76877078?v=4&s=18" alt="avatar" width="18"/> [Rinku Chaudhari](https://togithub.com/therealrinku "+1/-1 (#5889 )") #### [1.5.1](https://togithub.com/axios/axios/compare/v1.5.0...v1.5.1) (2023-09-26) ##### Bug Fixes - **adapters:** improved adapters loading logic to have clear error messages; ([#5919](https://togithub.com/axios/axios/issues/5919)) ([e410779](https://togithub.com/axios/axios/commit/e4107797a7a1376f6209fbecfbbce73d3faa7859)) - **formdata:** fixed automatic addition of the `Content-Type` header for FormData in non-browser environments; ([#5917](https://togithub.com/axios/axios/issues/5917)) ([bc9af51](https://togithub.com/axios/axios/commit/bc9af51b1886d1b3529617702f2a21a6c0ed5d92)) - **headers:** allow `content-encoding` header to handle case-insensitive values ([#5890](https://togithub.com/axios/axios/issues/5890)) ([#5892](https://togithub.com/axios/axios/issues/5892)) ([4c89f25](https://togithub.com/axios/axios/commit/4c89f25196525e90a6e75eda9cb31ae0a2e18acd)) - **types:** removed duplicated code ([9e62056](https://togithub.com/axios/axios/commit/9e6205630e1c9cf863adf141c0edb9e6d8d4b149)) ##### Contributors to this release - <img src="https://avatars.githubusercontent.com/u/12586868?v=4&s=18" alt="avatar" width="18"/> [Dmitriy Mozgovoy](https://togithub.com/DigitalBrainJS "+89/-18 (#5919 #5917 )") - <img src="https://avatars.githubusercontent.com/u/110460234?v=4&s=18" alt="avatar" width="18"/> [David Dallas](https://togithub.com/DavidJDallas "+11/-5 ()") - <img src="https://avatars.githubusercontent.com/u/71556073?v=4&s=18" alt="avatar" width="18"/> [Sean Sattler](https://togithub.com/fb-sean "+2/-8 ()") - <img src="https://avatars.githubusercontent.com/u/4294069?v=4&s=18" alt="avatar" width="18"/> [Mustafa Ateş Uzun](https://togithub.com/0o001 "+4/-4 ()") - <img src="https://avatars.githubusercontent.com/u/132928043?v=4&s=18" alt="avatar" width="18"/> [Przemyslaw Motacki](https://togithub.com/sfc-gh-pmotacki "+2/-1 (#5892 )") - <img src="https://avatars.githubusercontent.com/u/5492927?v=4&s=18" alt="avatar" width="18"/> [Michael Di Prisco](https://togithub.com/Cadienvan "+1/-1 ()") ##### PRs - CVE 2023 45857 ( [#6028](https://api.github.com/repos/axios/axios/pulls/6028) ) ``` ⚠️ Critical vulnerability fix. See https://security.snyk.io/vuln/SNYK-JS-AXIOS-6032459 ``` </details> <details> <summary>import-js/eslint-plugin-import (eslint-plugin-import)</summary> ### [`v2.29.0`](ht </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 5am on sunday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/SvenKirschbaum/share.kirschbaum.cloud).

docs(secretsmanager): doc when automaticallyAfter for RotationSchedul…

21785e2

…e is 0 is wrong

aws-cdk-automation requested a review from a team October 17, 2023 06:49

github-actions bot added admired-contributor [Pilot] contributed between 13-24 PRs to the CDK p2 labels Oct 17, 2023

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 17, 2023

lpizzinidev suggested changes Oct 17, 2023

View reviewed changes

add validation for if automaticallyAfter > 1000

324066e

go-to-k changed the title ~~docs(secretsmanager): doc when automaticallyAfter for RotationSchedule is 0 is wrong~~ chore(secretsmanager): modify doc and validation for automaticallyAfter for RotationSchedule Oct 17, 2023

go-to-k added 3 commits October 18, 2023 11:14

tweak for error message

0f8bbf3

tweak for a doc

d0dd6d0

tweak for a test

51a4a12

lpizzinidev suggested changes Oct 18, 2023

View reviewed changes

go-to-k added 3 commits October 18, 2023 17:54

drop without docs

7be4cee

add comments for maximum value

eb2392d

tweak

c161bfb

go-to-k changed the title ~~chore(secretsmanager): modify doc and validation for automaticallyAfter for RotationSchedule~~ docs(secretsmanager): doc when automaticallyAfter for RotationSchedule is 0 is wrong Oct 18, 2023

change comments

23e3422

go-to-k mentioned this pull request Oct 18, 2023

feat(secretsmanager): validate maximum value of automaticallyAfter in RotationSchedule #27592

Merged

lpizzinidev approved these changes Oct 18, 2023

View reviewed changes

aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Oct 18, 2023

kaizencc approved these changes Oct 18, 2023

View reviewed changes

Merge branch 'main' into docs/secrets-rotaion-schedule

d28ac34

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 18, 2023

mergify bot merged commit 671b760 into aws:main Oct 18, 2023
12 checks passed

go-to-k deleted the docs/secrets-rotaion-schedule branch October 19, 2023 00:33

go-to-k mentioned this pull request Oct 23, 2023

(aws_secretsmanager): automaticallyAfter is not disabling the automatic rotation of secrets #27460

Open

github-actions bot mentioned this pull request Nov 1, 2023

Monthly PR metrics report - October 2023 #27786

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs(secretsmanager): doc when automaticallyAfter for RotationSchedule is 0 is wrong #27570

docs(secretsmanager): doc when automaticallyAfter for RotationSchedule is 0 is wrong #27570

go-to-k commented Oct 17, 2023 •

edited

Loading

lpizzinidev left a comment •

edited

Loading

go-to-k commented Oct 17, 2023

lpizzinidev left a comment •

edited

Loading

lpizzinidev Oct 18, 2023

go-to-k Oct 18, 2023

lpizzinidev Oct 18, 2023

go-to-k Oct 18, 2023

go-to-k commented Oct 18, 2023

go-to-k commented Oct 18, 2023

mergify bot commented Oct 18, 2023

aws-cdk-automation commented Oct 18, 2023

mergify bot commented Oct 18, 2023

-   *
+   *
+   * The maximum value is 1000 days.
+   *

	if (!props.automaticallyAfter \|\| props.automaticallyAfter.toMilliseconds() !== 0) {
	if (props.automaticallyAfter?.toMilliseconds() !== 0) {

docs(secretsmanager): doc when automaticallyAfter for RotationSchedule is 0 is wrong #27570

docs(secretsmanager): doc when automaticallyAfter for RotationSchedule is 0 is wrong #27570

Conversation

go-to-k commented Oct 17, 2023 • edited Loading

lpizzinidev left a comment • edited Loading

Choose a reason for hiding this comment

go-to-k commented Oct 17, 2023

lpizzinidev left a comment • edited Loading

Choose a reason for hiding this comment

lpizzinidev Oct 18, 2023

Choose a reason for hiding this comment

go-to-k Oct 18, 2023

Choose a reason for hiding this comment

lpizzinidev Oct 18, 2023

Choose a reason for hiding this comment

go-to-k Oct 18, 2023

Choose a reason for hiding this comment

go-to-k commented Oct 18, 2023

go-to-k commented Oct 18, 2023

mergify bot commented Oct 18, 2023

aws-cdk-automation commented Oct 18, 2023

AWS CodeBuild CI Report

mergify bot commented Oct 18, 2023

go-to-k commented Oct 17, 2023 •

edited

Loading

lpizzinidev left a comment •

edited

Loading

lpizzinidev left a comment •

edited

Loading