Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ec2): clarify error message for vpc sizing error #27550

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

msambol
Copy link
Contributor

@msambol msambol commented Oct 15, 2023

Subnet size must be minimum /28. This clarifies the error message.

Closes #27479.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@msambol
Copy link
Contributor Author

msambol commented Oct 15, 2023

@indrora This is what I was thinking.

@github-actions github-actions bot added the admired-contributor [Pilot] contributed between 13-24 PRs to the CDK label Oct 15, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team October 15, 2023 20:13
@github-actions github-actions bot added bug This issue is a bug. p2 labels Oct 15, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 15, 2023
kaizencc
kaizencc previously approved these changes Oct 16, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 16, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 16, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 16, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed kaizencc’s stale review October 16, 2023 18:49

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b48903a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 16, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit ba3258d into aws:main Oct 16, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admired-contributor [Pilot] contributed between 13-24 PRs to the CDK bug This issue is a bug. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_cdk.ec2.VPC: Confusing error for valid CIDR range, but using /28
3 participants